Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing an instruction breakpoint removes them all #212496

Closed
thegecko opened this issue May 11, 2024 · 3 comments · Fixed by #214162
Closed

Removing an instruction breakpoint removes them all #212496

thegecko opened this issue May 11, 2024 · 3 comments · Fixed by #214162
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly insiders-released Patch has been released in VS Code Insiders
Milestone
June 2024

Comments

@thegecko
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.89
  • OS Version: MacOS

Steps to Reproduce:

  1. Start a debug session and open the disassembly view
  2. Add a few instruction breakpoints, they appear in the breakpoints window
  3. In the breakpoints window, use the context menu to remove a single instruction breakpoint
  4. All instruction breakpoints are removed

May be related (although this no longer seems to be an issue in my testing): #129572
@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.89.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@thegecko thegecko mentioned this issue May 11, 2024
Closed
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly labels Jun 3, 2024
@roblourens roblourens added this to the June 2024 milestone Jun 3, 2024
roblourens added a commit that referenced this issue Jun 3, 2024
@roblourens
Use correct offset when removing instruction breakpoints
c12969c 
Fix #212496
@roblourens roblourens mentioned this issue Jun 3, 2024
Merged
roblourens added a commit that referenced this issue Jun 3, 2024
@roblourens
Use correct offset when removing instruction breakpoints (#214162)
2a2a0db 
Fix #212496
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 3, 2024
@thegecko
Copy link
Contributor Author

thegecko commented Jun 4, 2024 •
edited

@roblourens looks like you missed my fix for this at #212497

@roblourens
Copy link
Member

Oh, sorry @thegecko! Totally missed that it is linked right here from this issue...

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues debug-disassembly insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
June 2024
3 participants
@thegecko @roblourens @VSCodeTriageBot