Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: vscode extension defaults should show all projects #30811

Closed
callpraths opened this issue May 15, 2024 · 3 comments
Closed

[Bug]: vscode extension defaults should show all projects #30811

callpraths opened this issue May 15, 2024 · 3 comments

Comments

@callpraths
Copy link

callpraths commented May 15, 2024

Note from maintainers

There were some significant changes in the latest release of the VS Code Extension.
If you have problems with running tests, selecting projects and configuration,
running setup projects etc. after upgrading to the the recent version of the extension,
please read our FAQ.


Version

v1.1.1

Steps to reproduce

Expected behavior

v1.1.1 shipped the feature to be able to select the playwright projects to execute, and the test explorer now only shows the projects that are selected.

Prior to v1.1.1, all projects were shown in test explorer. I expected the list of tests shown to not change as I did not take any action to remove tests / projects.

Actual behavior

By default, my relevant projects were not selected (a dummy project that doesn't have many tests happened to be selected) and I had to figure out where to go select the project I care about.

Additional context

I love the ability to select projects. The problem here is with sensible defaults - coming into v1.1.1 I expected that I don't have to take any action to be able to continue seeing the tests that I did previously.

Environment

System:
    OS: Windows 10 10.0.REDACTED
    Memory: 34.58 GB / 63.59 GB
  Binaries:
    Node: 20.13.1 - REDACTED
    Yarn: 1.22.10 - REDACTED
    npm: 10.5.2 - REDACTED
  Languages:
    Bash: 5.1.16
@Phoenixmatrix
Copy link

Phoenixmatrix commented May 16, 2024

We hit the same issue, and it happened as we onboarded an engineer who hadn't used playwright before, leading to much co fusion.

Worse, we have a setup test, and that's the one that got selected by default, so we only had a single test.

I echo that comment. They should all be selected by default. It doesn't just impact the vs code extension: the playwright UI has the same behavior.

The extension settings get saved to the workspace settings too, so anyone who changes this locally then has to ignore or revert the settings file in git.

@yury-s
Copy link
Member

yury-s commented May 17, 2024

Note from maintainers

There were some significant changes in the latest release of the VS Code Extension.
If you have problems with running tests, selecting projects and configuration,
running setup projects etc. after upgrading to the the recent version of the extension,
please read our FAQ.

If the FAQ does not resolve your issue, please file a new bug.

@yury-s yury-s closed this as completed May 17, 2024
@callpraths
Copy link
Author

Thank you for the super-de-duper turnaround time on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants