Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: migrate repo to prettier v3 #31408

Open
1 task done
Hotell opened this issue May 17, 2024 · 0 comments
Open
1 task done

[Feature]: migrate repo to prettier v3 #31408

Hotell opened this issue May 17, 2024 · 0 comments
Labels

Comments

@Hotell
Copy link
Contributor

Hotell commented May 17, 2024

Library

all

Describe the feature that you would like added

We are running into intermittent issues on CI when invoking prettier.format within our nx workspace generators suite.

Because @nx/devkit formatFiles is using prettier v3 the format call is awaited as v3 switched to async APIs(Breaking Change) but we have pinned prettier version within repo to v2. Now this api inconsistency might be the cause of those intermittent issues.

Task:

  • migrate whole repo to prettier v3
  • POC PR chore: migrate repo to prettier v3 #31407
  • now because northstar uses prettier in various places where async behaviours cannot exists it creates a problematic way forward
  • additional blocker is storybook v6 which uses prettier v2 under the hood which might also cause inconsistencies

Blockers:

Have you discussed this feature with our team

No response

Additional context

No response

Validations

  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Priority

Normal

Related issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant