Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP White List integration tests for ISO example template #359

Open
2 tasks
ThePhen opened this issue Oct 8, 2019 · 0 comments
Open
2 tasks

IP White List integration tests for ISO example template #359

ThePhen opened this issue Oct 8, 2019 · 0 comments

Comments

@ThePhen
Copy link
Contributor

ThePhen commented Oct 8, 2019

Description

*As an ISO template engineer, I'd like to have integration tests that verify IP White List configuration is enacted on AZ resources.

As of this writing, there are unit tests that very that terraform plans reflect IP white list configuration settings, but they do not actually test that terraform apply has enacted such config upon Key Vaults and ACRs. Integration tests could cover this.

Acceptance Criteria

Reference: [Done-Done Checklist] (https://github.com/Microsoft/code-with-engineering-playbook/blob/master/Engineering/BestPractices/DoneDone.md)

  • IP white list configuration (e.g. provided by TF_VAR_resource_ip_whitelist) is enacted on the ACR and key vault resources under control of the ISO template.
  • Changing the IP whitelist between successive builds results in corrected configuration of the implicated resources

See PR #350 for more, especially this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant