Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Add customerize doc #362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP Add customerize doc #362

wants to merge 1 commit into from

Conversation

ianphil
Copy link
Contributor

@ianphil ianphil commented Oct 16, 2019

All Submissions:

  • [YES/NO] Have you followed the guidelines in our Contributing document?
  • [YES/NO] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [YES/NO] I have updated the documentation accordingly.
  • [YES/NO/NA] I have added tests to cover my changes.
  • [YES/NO/NA] All new and existing tests passed.
  • [YES/NO/NA] My code follows the code style of this project.
  • [YES/NO/NA] I ran lint checks locally prior to submission.
  • [YES/NO] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • [YES/NO]

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@ianphil ianphil added the wip label Oct 16, 2019
@ianphil ianphil self-assigned this Oct 16, 2019
TechnicallyWilliams
TechnicallyWilliams reviewed Oct 17, 2019
View reviewed changes
docs/6_CUSTOMERIZE_TEMPLATE.md

## 6.2 Goals and Objectives
< Outline the goals and takeaways of this walkthrough/lab >
To save so much time that we can actually enjoy our log walks on the beach, horse back rides, video game competition, whatevs...
- To create a file that references the template in the HLD repo and sets required params
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- To create a file that references the template in the HLD repo and sets required params
- To create a terraform file that references the template in the HLD repo and sets required params

@TechnicallyWilliams TechnicallyWilliams added the documentation Applies to documentation and diagrams label Oct 31, 2019
@TechnicallyWilliams TechnicallyWilliams linked an issue Jun 27, 2020 that may be closed by this pull request
Customerize your template for the app team #354
Open
4 tasks
KeithJRome
KeithJRome reviewed Nov 19, 2021
View reviewed changes
Copy link
Contributor

@KeithJRome KeithJRome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(reviewing to remove from my global pending PR queue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeithJRome KeithJRome KeithJRome left review comments

@TechnicallyWilliams TechnicallyWilliams TechnicallyWilliams left review comments

@nmiodice nmiodice Awaiting requested review from nmiodice

@erikschlegel erikschlegel Awaiting requested review from erikschlegel erikschlegel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ianphil ianphil

Labels
documentation Applies to documentation and diagrams wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customerize your template for the app team
3 participants
@ianphil @KeithJRome @TechnicallyWilliams