Measure display width in tuple formatter #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
barcharcraz
requested changes
May 14, 2024
StephanTLavavej
approved these changes
May 16, 2024
|
I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
barcharcraz
approved these changes
May 20, 2024
|
Thanks for fixing this runtime correctness bug in a hopefully-popular new feature! 😻 🐞 🛠️ |
JMazurkiewicz
added a commit
to JMazurkiewicz/STL
that referenced
this pull request
May 26, 2024
Addresses microsoft#4631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the tuple formatter uses
static_cast<int>(_Tmp_buf.size())to compute the width of output (in order to determine the number of fill characters to insert). This gives the wrong width if_Tmp_buf.size()is larger thanINT_MAX(see<format>: Misbehavior for huge strings #4479).Both problems can be avoided by using
_Measure_string_prefix, which computes the display width and clamps the result toINT_MAX(which means no fill character will be inserted).Closes #4479
While working on this, I noticed that the tuple formatter test uses
\u00d6which cannot be represented in some legacy text encodings. This PR adjusted the test to make it encoding-independent.Closes #4635
Future work: if no width is specified in the format string, there should be no need to use a temporary buffer. The use of
_Tmp_bufshould be skipped in this case.