Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide User informations and Logout buttons in unauthenticated mode #1138

Closed
lbroudoux opened this issue Apr 15, 2024 · 1 comment
Closed

Hide User informations and Logout buttons in unauthenticated mode #1138

lbroudoux opened this issue Apr 15, 2024 · 1 comment
Labels
component/ux good first issue keep-open Explicitily keep open kind/enhancement
Milestone
1.10

Comments

@lbroudoux
Copy link
Member

Reason/Context

When running Microcks without authentication/Keycloak support, we still have the User's information and Logout buttons that are available. This make things confusing such as in #1086

Description

We should hide those informations and buttons if not authentication support.

Implementation ideas

This is a UI only hack ;-)
@lbroudoux lbroudoux mentioned this issue Apr 15, 2024
Closed
Apoorva64 added a commit to Orange-OpenSource/microcks that referenced this issue May 24, 2024
@Apoorva64
fix: disable dropdown and info when in unauthenticated mode
d1ca2a4 
Resolves: microcks#1138
Signed-off-by: Apoorva Srinivas Appadoo <apoorva-srinivas.appadoo@etu.univ-cotedazur.fr>
@Apoorva64 Apoorva64 mentioned this issue May 24, 2024
Merged
Apoorva64 added a commit to Orange-OpenSource/microcks that referenced this issue May 24, 2024
@Apoorva64
refactor: use configService instead of ClassNames
50c54dc 
Resolves: microcks#1138
Signed-off-by: Apoorva Srinivas Appadoo <apoorva-srinivas.appadoo@etu.univ-cotedazur.fr>
Apoorva64 added a commit to Orange-OpenSource/microcks that referenced this issue May 24, 2024
@Apoorva64
docs: update jsdoc
b84f911 
Resolves: microcks#1138
Signed-off-by: Apoorva Srinivas Appadoo <apoorva-srinivas.appadoo@etu.univ-cotedazur.fr>
lbroudoux pushed a commit that referenced this issue May 28, 2024
@Apoorva64
fix: disable dropdown and info when in unauthenticated mode (#1179)
14ef5d0 
* fix: disable dropdown and info when in unauthenticated mode

Resolves: #1138
Signed-off-by: Apoorva Srinivas Appadoo <apoorva-srinivas.appadoo@etu.univ-cotedazur.fr>

* refactor: use configService instead of ClassNames

Resolves: #1138
Signed-off-by: Apoorva Srinivas Appadoo <apoorva-srinivas.appadoo@etu.univ-cotedazur.fr>

* docs: update jsdoc

Resolves: #1138
Signed-off-by: Apoorva Srinivas Appadoo <apoorva-srinivas.appadoo@etu.univ-cotedazur.fr>

---------

Signed-off-by: Apoorva Srinivas Appadoo <apoorva-srinivas.appadoo@etu.univ-cotedazur.fr>
@lbroudoux lbroudoux added this to the 1.10 milestone May 28, 2024
@lbroudoux
Copy link
Member Author

Fixed in #1179. Thanks to @Apoorva64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/ux good first issue keep-open Explicitily keep open kind/enhancement
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
1 participant
@lbroudoux