Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prolog support #127

Open
michaelb opened this issue Dec 13, 2021 · 5 comments
Open

Prolog support #127

michaelb opened this issue Dec 13, 2021 · 5 comments
Labels
new-langage-support request for supporting a new language

Comments

@michaelb
Copy link
Owner

Describe the language you want support for (compiler, specificities)
prolog

Support Level to achieve
bloc-level

Additional context
wip; src/interpreters/Prolog_gnu.rs

@michaelb michaelb added the new-langage-support request for supporting a new language label Dec 13, 2021
@michaelb
Copy link
Owner Author

@tani I merged your PR and made appropriate adjustments to some things, but this work is not complete yet.

Could you re-sync your fork and see what has to be done to have a working Prolog interpreter? (at least having the test you wrote pass)

@tani
Copy link
Contributor

tani commented Dec 15, 2021

@michaelb Okay! Thanks. I check it now.

@tani
Copy link
Contributor

tani commented Dec 15, 2021

doc/Prolog_gnu

In my understanding, the naming rule of your project is as follows;

  • Programming language name as the first part
  • Variation of interpreter/compiler as the second part

Prolog is a programming name. GNU Prolog and SWI Prolog are independent interpreters such as GCC and Clang. I mean, we should distinct SWI Prolog and GNU Prolog in some sense. Precisely speaking, we cannot use SWI Prolog to replace GNU Prolog because the interface is not compatible with the others.

I request you to add Prolog_swi again and update documents.
Or, how about renaming Prolog_gnu to Prolog_original

CONTRIBUTING_REPL.md

This is the awesome document I wanted.

On L18 in CONTRIBUTING_REPL.md, we see the typo stdin/stdou/stderr.
On L21, please remove the leading space for better markdown compliance.

@michaelb
Copy link
Owner Author

how about renaming Prolog_gnu to Prolog_original

Done, on the dev branch (re-sync your fork if you want to start from here). You're totally right, it's clearer.

This is the awesome document I wanted.

You're welcome. The small fixes you wanted are also on the dev branch

I request you to add Prolog_swi again

Oh, also. I'm the last person that would be offended, moreover I know that no one writes perfect english, but as a general rule in open-source, don't 'request' or 'demand'. 'Ask', or use softer words 'could you'/'would it be possible to'

@tani
Copy link
Contributor

tani commented Dec 15, 2021

Thank you for listening to my comments. I'm sorry if my English makes me uncomfortable. I learned about more gentlemanly phrases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-langage-support request for supporting a new language
Projects
None yet
Development

No branches or pull requests

2 participants