How to programmatically remove a breakpoint from active session?

[ibhagwan]

Fzf-lua enables fuzzy searching of dap breakpoints, it also enables deleting selected breakpoints with ctrl-x, the code below removes the breakpoint from the sign column and my most recent attempt also removes it from an active session, however, that only works some of the times, for example it works debugging lua files (one-step-for-vimkind) but fails when used with vscode-cpptools.

By “fails” I mean, the breakpoint is removed from the UI sign column, also reflected by dap.breakpoints.get() but the change doesn’t seem to be propagated to gdb as the breakpoint is still hit and I also see it if I run -exec info br in the DAP REPL.

I also tried to copy the broadcast code found in nvim-dap that iterated the sessions’s children but it made no effect as I only had one session:

nvim-dap/lua/dap.lua

Lines 803 to 810 in 405df1d

	---@param lsessions table<integer, Session>
	---@param fn fun(lsession: Session)
	local function broadcast(lsessions, fn)
	for _, lsession in pairs(lsessions) do
	fn(lsession)
	broadcast(lsession.children, fn)
	end
	end

The below is my most recent code, what else do I need to call aside from session:set_breakpoints(…)?

M.dap_bp_del = function(selected, opts)
  local dap_bps = require("dap.breakpoints")
  for _, e in ipairs(selected) do
    local entry = path.entry_to_file(e, opts)
    if entry.bufnr > 0 and entry.line then
      dap_bps.remove(entry.bufnr, entry.line)
    end
  end
  -- removing the BP will update the UI, if we're in session
  -- we also need to broadcast the BP delete to the DAP server
  local session = require("dap").session()
  if session then
    local bps = dap_bps.get()
    session:set_breakpoints(bps)
  end
end

[ibhagwan]

Oh well, that didn't take long I answered myself :-)

Turns out that if I delete the last bp in a buffer I must set the bp[index] = {} in order to clear all breakpionts, my latest working code:

M.dap_bp_del = function(selected, opts)
  local bufnrs = {}
  local dap_bps = require("dap.breakpoints")
  for _, e in ipairs(selected) do
    local entry = path.entry_to_file(e, opts)
    if entry.bufnr > 0 and entry.line then
      dap_bps.remove(entry.bufnr, entry.line)
      table.insert(bufnrs, tonumber(entry.bufnr))
    end
  end
  -- removing the BP will update the UI, if we're in session
  -- we also need to broadcast the BP delete to the DAP server
  local session = require("dap").session()
  if session then
    local bps = dap_bps.get()
    for _, b in ipairs(bufnrs) do
      -- If all BPs were removed from a buffer we must clear the buffer
      -- by sending an empty table in the bufnr index
      bps[b] = bps[b] or {}
    end
    session:set_breakpoints(bps)
  end
end