Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use relative link for geojson maps #42767

Closed
dpsutton opened this issue May 16, 2024 · 1 comment · Fixed by #43491
Closed

Don't use relative link for geojson maps #42767

dpsutton opened this issue May 16, 2024 · 1 comment · Fixed by #43491
Assignees
Labels
Embedding/ Use this label when unsure which flavor of embedding is impacted Misc/API .Team/AdminWebapp Admin and Webapp team Visualization/Maps

Comments

@dpsutton
Copy link
Contributor

From @oisincoveney

Hey backend team! I have a quick question for y'all. Right now we're trying to embed a static dashboard using the Embedding SDK, but one snag that we found was that the geojson maps that we use for the visualizations aren't loading, since the links to the map are using a relative URL. That means that if a client has a map visualization on, for example, localhost:420420/admin/whatever, the SDK tried to fetch the map from localhost:420420/admin/whatever/app/assets/geojson/us-states.json .
I see that it's initialized to this relative url within the geojson.clj file as a setting. Do you think we could do something to explicitly specify the backend URL so it looks like [MB_BACKEND_URL]/app/assets/geojson/us-states.json? Or is there something else that we should do?

@dpsutton dpsutton added Misc/API Embedding/ Use this label when unsure which flavor of embedding is impacted Visualization/Maps .Team/AdminWebapp Admin and Webapp team labels May 16, 2024
@NevRA
Copy link
Contributor

NevRA commented May 23, 2024

@dpsutton any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embedding/ Use this label when unsure which flavor of embedding is impacted Misc/API .Team/AdminWebapp Admin and Webapp team Visualization/Maps
Projects
None yet
3 participants