[Bug] Cannot use offsetted column as a base for another offsetted column #42764
Labels
Comments
kamilmielnik
added
Type:Bug
kamilmielnik
changed the title
|
This has been addressed by #42736. Now offset-based columns are not visible (or filterable, or expressionable, etc.) |
kamilmielnik
added a commit
that referenced
this issue
May 21, 2024
* [MBQL lib] Reject broken uses of `offset` in expressions, filters (#42662) - Using `offset` in custom expressions is supported only when there is an order-by defined on that stage. - Using `offset` in custom filters is not supported at all, currently. * Support `Offset()` in custom columns [frontend] (#42326) * Only nest expressions referenced in breakouts or aggregations * Support Offset() as expression with no breakouts * Test fixes 🔧 * Oracle test update * Improved Oracle test * Test update 🔧 * Fix busted test * Add naive support for Offset() in expressions * Introduce MBQLClauseFunctionReturnType * Add "window" to MBQLClauseFunctionReturnType and use it for the offset function * Handle offset type inference * Remove unused export * Use "expression" instead of "window" return type - Rename identifiers in isCompatible - Make isCompatible accept a clause object instead of just the type - Handle offset as a special case in isCompatible * Use any type * Rename expectedArgumentType to expectedType * Format code * Sort types * Do not suggest offset function in filters * Fix offset not working in case * Revert "Do not suggest offset function in filters" This reverts commit e63790b. * Fix order of adjustments --------- Co-authored-by: Cam Saul <github@camsaul.com> Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com> * Disable offsets in filters expressions * Group existing aggregations-specific tests * Remove repro for a closed issue * Use findByText instead of contains * Add a test for filter expressions * Add a test for aggregation expressions suggestions * Disable offsets in filters expressions (#42755) * Add a test for custom column suggestions * Add "typing" to enterCustomColumnDetails * Use enterCustomColumnDetails, improve assertions * Add more assertions * Optimize queries * Add typing for offset expressions * Add a repro for #42764 * Add a TODO * Add a TODO * Add a TODO * Use NumericLiteral * Post-merge fixes * Update test * Add tests for other custom expressions * Test drills * Format code * Update test name * Add an assertion * Add assertions for the preview * Unskip fixed issue --------- Co-authored-by: Braden Shepherdson <braden@metabase.com> Co-authored-by: Cam Saul <github@camsaul.com> Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this issue
May 21, 2024
* [MBQL lib] Reject broken uses of `offset` in expressions, filters (#42662) - Using `offset` in custom expressions is supported only when there is an order-by defined on that stage. - Using `offset` in custom filters is not supported at all, currently. * Support `Offset()` in custom columns [frontend] (#42326) * Only nest expressions referenced in breakouts or aggregations * Support Offset() as expression with no breakouts * Test fixes 🔧 * Oracle test update * Improved Oracle test * Test update 🔧 * Fix busted test * Add naive support for Offset() in expressions * Introduce MBQLClauseFunctionReturnType * Add "window" to MBQLClauseFunctionReturnType and use it for the offset function * Handle offset type inference * Remove unused export * Use "expression" instead of "window" return type - Rename identifiers in isCompatible - Make isCompatible accept a clause object instead of just the type - Handle offset as a special case in isCompatible * Use any type * Rename expectedArgumentType to expectedType * Format code * Sort types * Do not suggest offset function in filters * Fix offset not working in case * Revert "Do not suggest offset function in filters" This reverts commit e63790b. * Fix order of adjustments --------- Co-authored-by: Cam Saul <github@camsaul.com> Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com> * Disable offsets in filters expressions * Group existing aggregations-specific tests * Remove repro for a closed issue * Use findByText instead of contains * Add a test for filter expressions * Add a test for aggregation expressions suggestions * Disable offsets in filters expressions (#42755) * Add a test for custom column suggestions * Add "typing" to enterCustomColumnDetails * Use enterCustomColumnDetails, improve assertions * Add more assertions * Optimize queries * Add typing for offset expressions * Add a repro for #42764 * Add a TODO * Add a TODO * Add a TODO * Use NumericLiteral * Post-merge fixes * Update test * Add tests for other custom expressions * Test drills * Format code * Update test name * Add an assertion * Add assertions for the preview * Unskip fixed issue --------- Co-authored-by: Braden Shepherdson <braden@metabase.com> Co-authored-by: Cam Saul <github@camsaul.com> Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
metabase-bot bot
added a commit
that referenced
this issue
May 21, 2024
* [MBQL lib] Reject broken uses of `offset` in expressions, filters (#42662) - Using `offset` in custom expressions is supported only when there is an order-by defined on that stage. - Using `offset` in custom filters is not supported at all, currently. * Support `Offset()` in custom columns [frontend] (#42326) * Only nest expressions referenced in breakouts or aggregations * Support Offset() as expression with no breakouts * Test fixes 🔧 * Oracle test update * Improved Oracle test * Test update 🔧 * Fix busted test * Add naive support for Offset() in expressions * Introduce MBQLClauseFunctionReturnType * Add "window" to MBQLClauseFunctionReturnType and use it for the offset function * Handle offset type inference * Remove unused export * Use "expression" instead of "window" return type - Rename identifiers in isCompatible - Make isCompatible accept a clause object instead of just the type - Handle offset as a special case in isCompatible * Use any type * Rename expectedArgumentType to expectedType * Format code * Sort types * Do not suggest offset function in filters * Fix offset not working in case * Revert "Do not suggest offset function in filters" This reverts commit e63790b. * Fix order of adjustments --------- * Disable offsets in filters expressions * Group existing aggregations-specific tests * Remove repro for a closed issue * Use findByText instead of contains * Add a test for filter expressions * Add a test for aggregation expressions suggestions * Disable offsets in filters expressions (#42755) * Add a test for custom column suggestions * Add "typing" to enterCustomColumnDetails * Use enterCustomColumnDetails, improve assertions * Add more assertions * Optimize queries * Add typing for offset expressions * Add a repro for #42764 * Add a TODO * Add a TODO * Add a TODO * Use NumericLiteral * Post-merge fixes * Update test * Add tests for other custom expressions * Test drills * Format code * Update test name * Add an assertion * Add assertions for the preview * Unskip fixed issue --------- Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by: Braden Shepherdson <braden@metabase.com> Co-authored-by: Cam Saul <github@camsaul.com> Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
e2e repro (skipped for now) here: #42756
Repro steps:
Total-1with this expression:Offset([Total], -1)Total-2with this expression:Offset([Total-1], -1)The text was updated successfully, but these errors were encountered: