-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Long running commands should include a spinner animation #7803
Comments
We currently use meltano/src/cloud-cli/meltano/cloud/cli/deployment.py Lines 412 to 419 in 47d1d3d
That is to say, we can easily use this elsewhere in the Meltano CLI, and we won't have to add any additional dependencies to do so. |
@WillDaSilva @BraedonLeonard can I pick this? |
Sure thing @ashu565! |
@WillDaSilva can I take this up if no one is working? if not flags.get("no_install"):
- success = install_plugins(
- project,
- plugins,
- reason=PluginInstallReason.ADD,
- force=flags.get("force_install", False),
- )
if not flags.get("no_install"):
+ with yaspin(
+ text="Installing Plugins - this may take several minutes...",
+ ):
+ success = install_plugins(
+ project,
+ plugins,
+ reason=PluginInstallReason.ADD,
+ force=flags.get("force_install", False),
+ ) Please let me know if I'm on the right track. Thanks! |
@raiatul14 That seems like the right track. We should give @ashu565 a day or so to see if they've got anything in the works, or if they're not planning on completing this anytime soon. If they aren't (or don't say anything), then please feel free to implement this. |
@WillDaSilva I tried to add the yaspin() snippet inside if install_state.status in {
PluginInstallStatus.RUNNING,
PluginInstallStatus.SKIPPED,
}:
with yaspin().bold.blink.magenta.bouncingBall.on_cyan:
msg = f"{install_state.verb} {desc} '{plugin.name}'..."
click.secho(msg) It works something like this Doesn't seem very convincing to me. Do you have any thoughts around this or can you guide me further please? Thanks! |
@raiatul14 The |
@WillDaSilva I have opened a PR related to this issue. Please review: #8234. |
Feature scope
CLI (options, error messages, logging, etc.)
Description
When I was working through the Getting Started guide, I got to the step where you install the airflow orchestrator. After running
meltano add orchestrator airflow
, the command will reach a point where it sits for multiple minutes with absolutely no feedback to the user. When this happens, it can be very hard to tell whether or not the program has frozen or not, so it would be reassuring to have a spinner animation of some kind for these commands to show that things are still happening.The text was updated successfully, but these errors were encountered: