bug: Wrong Pip URL When Using inherit_from

[wesseljt]

Meltano Version

2.1.0

Python Version

3.10

Bug scope

CLI (options, error messages, logging, etc.)

Operating System

Mac OS Intel

Description

FIRST SERVER (SQLSERVER)

  - name: tap-mssql
    variant: buzzcutnorman
    pip_url: git+https://github.com/BuzzCutNorman/tap-mssql.git

SECOND SERVER (SQLSERVER)

  - name: tap-mssql--1
    inherit_from: tap-mssql
    variant: buzzcutnorman
    pip_url: git+https://github.com/BuzzCutNorman/tap-mssql.git

CLI COMMAND

'''
meltano add extractor tap-mssql-3 --inherit-from tap-mssql --variant wintersrd
'''

CLI COMMAND PRODUCES:

THIRD SERVER (SQLSERVER) -- THIS DOESN'T WORK

  - name: tap-mssql--3
    inherit_from: tap-mssql
    variant: wintersrd
    pip_url: tap-mssql

THIRD SERVER (SQLSERVER) -- THIS WORKS - NEED FULL pip_url

  - name: tap-mssql--3
    inherit_from: tap-mssql
    variant: wintersrd
    pip_url: git+https://github.com/wintersrd/pipelinewise-tap-mssql.git

This was a little confusing to work through but the solution above works fine. I believe this same issue would impact other taps. Specifically there is a report in slack of it impacting Postgres.

slack link:https://meltano.slack.com/archives/C01TCRBBJD7/p1693319908339669

Code

No response

[edgarrmondragon]

Hi @wesseljt!

At the moment Meltano doesn't have great support for installing different variants of the same plugin side by side (see #6731), so thanks for reporting the problem and your workaround.

Though I'm curious what's wrong with this

  - name: tap-mssql--3
    inherit_from: tap-mssql
    variant: wintersrd
    pip_url: tap-mssql

That package specifier indeed corresponds to the wintersd repo: https://pypi.org/project/tap-mssql/

[wesseljt]

Got it - thanks @edgarrmondragon. So my tap-mssql that it inherits from is not the default tap its a variant (buzzcutnorman). I suspect this contributed somehow but don't know how. My theory was it was grabbing the buzzcutnorman pip_url from tap-mssql it inherited from and that would have been the buzzcutnorman url not the wintersrd url. Hopefully that makes sense. But I'm not 100% sure of this and didn't have a way to easily prove this.