Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find FaceSwap anymore, what happend? [bug] #128

Open
HenryFroio opened this issue Nov 20, 2023 · 3 comments
Open

Can't find FaceSwap anymore, what happend? [bug] #128

HenryFroio opened this issue Nov 20, 2023 · 3 comments
Assignees
Labels
🎭 Face nodes Related to the faceswap or facerestore nodes type: 📄 documentation Improvements or additions to documentation

Comments

@HenryFroio
Copy link

Describe the bug

Well, the title is self explanatory

Captura de tela 2023-11-20 175340

Captura de tela 2023-11-20 175411

Reproduction

No response

Expected behavior

No response

Operating System

Linux

Comfy Mode

In a custom virtual env (venv, virtualenv, conda...)

Console output

No response

Additional context

No response

@HenryFroio HenryFroio added status: 🧹 needs triage This issue needs to triage, applied to new issues type: 🐛 bug Something isn't working labels Nov 20, 2023
@melMass
Copy link
Owner

melMass commented Nov 21, 2023

Hi,

Thanks for the report, yes I actually removed them from the "setup" because they were a pain to maintain on windows (became impossible without using other approaches with Py11 afaik).

But other OSes work actually fine so I need to add instructions to properly install them. I personally still use all the optional nodes on windows and macos.

https://github.com/melMass/comfy_mtb?tab=readme-ov-file#optional-nodes

@melMass melMass added type: 📄 documentation Improvements or additions to documentation 🎭 Face nodes Related to the faceswap or facerestore nodes and removed type: 🐛 bug Something isn't working status: 🧹 needs triage This issue needs to triage, applied to new issues labels Nov 21, 2023
@J-Cott
Copy link

J-Cott commented Dec 19, 2023

Where do you run this command?
.venv/python -m pip install tensorflow facexlib insightface basicsr
In the \ComfyUI\custom_nodes\comfy_mtb\ folder?
I think they are not very clear instructions for most users.

EDIT: For me on the Portal ComfyUI it was: \ComfyUI_windows_portable\python_embeded\
python -m pip install tensorflow facexlib insightface basicsr

But I am still getting errors on the workflow from:

Evaluate Strings
Evaluate Floats
Evaluate Integers

But that could be unrelated to your extension.

@melMass
Copy link
Owner

melMass commented Dec 20, 2023

I will write better instructions did not have the time yet tbh.

That said I really recommend the alternatives listed in the readme as they are more up to date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎭 Face nodes Related to the faceswap or facerestore nodes type: 📄 documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants