New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly reports latest WebView as too old #24

Open

SkewedZeppelin opened this issue Jul 13, 2023 · 1 comment

SkewedZeppelin commented Jul 13, 2023 •

edited

webcall-android/src/main/assets/webcall.js

Lines 42 to 47 in 1a485a0

    
           var webviewVersion = Android.webviewVersion(); 
        
           if(!webviewVersion) { 
        
           	webviewVersion = "no version, old webview?"; 
        
           } else if(webviewVersion<"80.0") { 
        
           	webviewVersion = webviewVersion + " TOO OLD!"; 
        
           }

Latest WebView 115.0.5790.85 ends up labeled "TOO OLD"

likely because of plain string comparison, vs splitting out major version and converting to int

Owner

mehrvarz commented Jul 14, 2023

This will be resolved with the next release. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment