Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix code snippet for webpack custom configurations #7188

Merged
merged 2 commits into from
May 8, 2024
Merged

docs: fix code snippet for webpack custom configurations #7188

merged 2 commits into from
May 8, 2024

Conversation

shahednasser
Copy link
Member

Fix the code snippet in the admin's webpack custom configurations to use CJS rather than ESM

Closes #7187

@shahednasser
docs: fix code snippet for webpack custom configurations
fce9c27 
Fix the code snippet in the admin's webpack custom configurations to use CJS rather than ESM

Closes #7187
@shahednasser shahednasser requested a review from a team as a code owner May 1, 2024 07:08
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 1, 2024 •
edited

⚠️ No Changeset found

Latest commit: 989c747

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 1, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview May 1, 2024 10:00am
docs-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 10:00am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 10:00am
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 10:00am

@shahednasser shahednasser changed the base branch from develop to v1.x May 6, 2024 11:43
@shahednasser shahednasser merged commit 3691e4c into v1.x May 8, 2024
30 checks passed
@shahednasser shahednasser deleted the docs/fix-webpack-config-snippet branch May 8, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

Assignees
No one assigned
Labels
team: medusa type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs(Code Issue): Code Issue in /admin/configuration
2 participants
@shahednasser @olivermrbl