Bug: CSV import creates duplicate when creating new categories

[jakubkottnauer]

Where did this bug occur?

• Local development
• Self hosted app (i.e. Docker)

Describe the bug
New categories present in the CSV being imported are created on every occurrence, instead of just once.

To Reproduce
Steps to reproduce the behavior:

1. Import the following CSV

date,name,category,amount
2024-01-01,Starbucks drink,SOMETHING_NEW,20
2024-01-02,Amazon stuff,SOMETHING_NEW,200

2. Observe that the SOMETHING_NEW category has been created twice

Expected behavior
New categories are only created once

[zachgoll]

@jakubkottnauer good catch here. This is the relevant method we'll need to rework. I think the challenge here is that we'll need to create a data structure that allows us to know in what order to call .save on each model. We may even need to rework the "preview -> save" flow a bit.

maybe/app/models/import.rb

Lines 109 to 125 in 34811d8

	def generate_transactions
	transactions = []
	csv.table.each do |row|
	category = account.family.transaction_categories.find_or_initialize_by(name: row["category"])
	txn = account.transactions.build \
	name: row["name"] || "Imported transaction",
	date: Date.iso8601(row["date"]),
	category: category,
	amount: BigDecimal(row["amount"]) * -1, # User inputs amounts with opposite signage of our internal representation
	currency: account.currency
	transactions << txn
	end
	transactions
	end