Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with v14.1.0 regarding ~~strikethrough text~~ #1024

Open
Lucas-C opened this issue May 14, 2024 · 1 comment
Open

Regression with v14.1.0 regarding ~~strikethrough text~~ #1024

Lucas-C opened this issue May 14, 2024 · 1 comment

Comments

@Lucas-C
Copy link

Lucas-C commented May 14, 2024

Hi

Thank you for maintining markdown-it!

I discovered a minor regression with the latest published version:

$ node -v
v18.19.1

$ npm i markdown-it@14.0.0

$ node -e 'console.log(require("markdown-it")().render("~~⚀~~one"))'
<p><s>⚀</s>one</p>

$ npm i markdown-it@14.1.0

$ node -e 'console.log(require("markdown-it")().render("~~⚀~~one"))'
<p>~~⚀~~one</p>

This bug only appears when using non-ASCII characters: it won't happen if is replaced by 1 in the sample code above.

@rlidwka
Copy link
Member

rlidwka commented May 16, 2024

This is so much easier to test different versions with:

$ echo "import md from 'npm:markdown-it@14.0.0'; console.log(md().render('~~⚀~~one'));" | deno run -
<p><s>⚀</s>one</p>
$ echo "import md from 'npm:markdown-it@14.1.0'; console.log(md().render('~~⚀~~one'));" | deno run -
<p>~~⚀~~one</p>

Thanks for the report. But I think that it is not a bug, but intentional change in the spec: #1009 (see point 3)

is Other Symbol (So), and the entire S class is now treated as punctuation which it wasn't before (so now behavior is the same as with ~~&~~one for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants