Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnimationType.vector animates in an incorrect direction #72

Open
marcosgriselli opened this issue Sep 5, 2020 · 3 comments
Open

AnimationType.vector animates in an incorrect direction #72

marcosgriselli opened this issue Sep 5, 2020 · 3 comments
Assignees
Labels

Comments

@marcosgriselli
Copy link
Owner

#70 introduced a new animation case called .vector(CGVector) which replaced the old .from(Direction, CGFloat) case. This new type has a bug where the animations are performed in an incorrect direction.

view.animate(animations: AnimationType.vector(CGVector(dx: 0, dy: 30)))

Should translate the view from top to bottom by 30 points but it's happening in a reversed order.

@marcosgriselli marcosgriselli self-assigned this Sep 5, 2020
@iTarek
Copy link

iTarek commented Sep 17, 2020

Hello, Do you have time to fix this issue?

@marcosgriselli
Copy link
Owner Author

@iTarek I added a comment on the PR a couple of days ago:

@iTarek after some review I believe the functionality is working as expected. I agree the API is a bit confusing but I'm testing >the example project and running this code:
let animation = AnimationType.vector(CGVector(dx: 0, dy: 30))
activityIndicator.animate(animations: [animation], reversed: true, initialAlpha: 1, finalAlpha: 0)
will effectively animate the view by moving it from its current position 30 points to the bottom. Can you maybe replicate the issue you're having on a PR or demo project?

@iTarek
Copy link

iTarek commented Sep 18, 2020

Ok now I understand what cause the problem...
Try to add icon in the middle of the screen
Add this animation

let animZoom = AnimationType.zoom(scale: 2.0)
loadingViewIcon.animate(animations: [animZoom], reversed: true, initialAlpha: 1, finalAlpha: 1, duration: 30.0)

Then after the app load I add this animation to make the icon fall down

let animMove = AnimationType.vector(CGVector(dx: 0, dy: self.view.height/2))
loadingViewIcon.animate(animations: [animMove], reversed: true, initialAlpha: 1, finalAlpha: 1, duration: 0.2)

Before the last update they both was working good with each other, but now they don't.
While the first animation still running the secound animation jump on the top of the screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants