Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include other options in string? #29

Open
ziggie216 opened this issue Mar 14, 2019 · 8 comments
Open

Include other options in string? #29

ziggie216 opened this issue Mar 14, 2019 · 8 comments

Comments

@ziggie216
Copy link

I noticed that YouTube-dl-server will stop if there is a private video listed YT playlist. Is there a way I can include —ignore-errors

@ohnggni
Copy link

ohnggni commented Mar 18, 2019

In order to include that options,
you have to modify 'youtube-dl-server.py' as in the following.

  1. add the statement, 'YDL_IGNORE_ERR': None, below the line 16 app_default = {
  2. add the statement, 'ignoreerrors': ydl_vars['YDL_IGNORE_ERR'], below the line 101(?) return {

after that, re-start the docker-container.

스크린샷 2019-03-19 오전 8 05 54

스크린샷 2019-03-19 오전 8 06 16

@manbearwiz
Copy link
Owner

manbearwiz commented Mar 19, 2019

Has anyone tried running with the ignore error flag enabled? Wondering if there is any harm in just enabling it by default. We don't really report any errors back to the user anyway.

@ohnggni
Copy link

ohnggni commented Mar 22, 2019

Has anyone tried running with the ignore error flag enabled? Wondering if there is any harm in just enabling it by default. We don't really report any errors back to the user anyway.

I learned this flag does not work in python based on this docker.
If any event (eg. any exception due to request of deleted clips) happened, youtube-dl-server.py was suspended and after that, I couldn't download any clip anymore. In order to escape this situation, it was the only way to restart the docker container.

I think we need some modification that the python script restarts automatically in case of happening any exception or error.

@manbearwiz
Copy link
Owner

Probably just need to catch and handle errors on that thread. Do you have a playlist you were testing with?

@ohnggni
Copy link

ohnggni commented Mar 22, 2019

Probably just need to catch and handle errors on that thread. Do you have a playlist you were testing with?

https://www.youtube.com/watch?v=wNtbfEaAw18&list=PLofOAS0adMaxoTfZf7HLJ5Vk3As5JuDtE&index=2

The link above is what I was testing. The fourth clip was deleted. So, when I tried to download it, the error happened and the process was suspended at that point. Then I tried downloading another clip(even very normal) but I couldn't do until I restarted the docker container.

@ohnggni
Copy link

ohnggni commented Mar 22, 2019

I've just found the solution.
The part of the code above are slightly wrong.
'YDL_IGNORE_ERR': None => True

After that, --ignore-errors works so well and youtube-dl-server.py weren't suspended anymore.

@manbearwiz
Copy link
Owner

Do you think I should make this the default setting?

@ohnggni
Copy link

ohnggni commented Mar 23, 2019

Yes, when we try to download playlists, oftentimes we experience that kind of error. Otherwise, we will always have to restart the docker-container whenever we meet any exception or error of python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants