Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing for and since in options in deprecations. #2268

Open
Mikek2252 opened this issue Feb 4, 2021 · 2 comments
Open

Missing for and since in options in deprecations. #2268

Mikek2252 opened this issue Feb 4, 2021 · 2 comments

Comments

@Mikek2252
Copy link
Collaborator

  • Ember Simple Auth: The AuthenticatedRouteMixin is now deprecated
  • Ember Simple Auth: The session service's events API is deprecated; to add custom behavior to the authentication or invalidation handling, override the handleAuthentication or handleInvalidation methods.
  • Ember Simple Auth: The ApplicationRouteMixin is now deprecated; it can be safely removed.

The following deprecations are missing the for and since options which are causing additional depreciations warnings.
Build 3.1.0

@IgorKvasn
Copy link
Contributor

this is the full message shown in the console
When calling `deprecate` you must provide `for` in options. Missing options.for in "ember-simple-auth.mixins.authenticated-route-mixin" deprecation [deprecation id: ember-source.deprecation-without-for]

@bartocc
Copy link
Contributor

bartocc commented Nov 29, 2021

Chiming in since I hit this deprecation message too today.

ESA won't be usable on ember 4.0 until this deprecation is removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants