Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Enable Flash Attention in the released binary #258

Open
JohnAlcatraz opened this issue May 11, 2024 · 0 comments
Open

Comments

@JohnAlcatraz
Copy link

JohnAlcatraz commented May 11, 2024

When I tried out the released binaries, I was surprised they do not have flash attention enabled. I mean these:

sd-master-ce1bcc7-bin-win-avx-x64.zip

sd-master-ce1bcc7-bin-win-avx2-x64.zip

sd-master-ce1bcc7-bin-win-avx512-x64.zip

The readme mentions this about flash attention:

Enabling flash attention reduces memory usage by at least 400 MB. At the moment, it is not supported when CUBLAS is enabled because the kernel implementation is missing.

The "bin-win-avx" CPU-only binaries don't have CUBLAS, so it shouldn't be any issue to enable flash attention, right?

When I then tried to compile the project myself with flash attention enabled, I also noticed that flash attention does not seem to work without manually disabling an assert (#138).

@JohnAlcatraz JohnAlcatraz changed the title Feature Request: Enable Flash Attention in the released binary [Feature Request] Enable Flash Attention in the released binary May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant