Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot type in a server name in the Remote SSH text box #3260

Closed
eldar opened this issue May 11, 2024 · 13 comments
Closed

Cannot type in a server name in the Remote SSH text box #3260

eldar opened this issue May 11, 2024 · 13 comments
Labels
C-bug Category: bug - something isn't working as it's supposed to

Comments

@eldar
Copy link

eldar commented May 11, 2024

Lapce Version

lapce-0.4.0+0ddc216

System information

Fedora 40 KDE Plasma Desktop

Describe the bug

I am trying to connect to a remote Linux server by clicking on "Connect to SSH host" which opens a text box on top of the editor, however I cannot type any text in the said textbox - it remains empty.

Additional information

Here is a screenshot demonstrating the issue

lapce_bug

@eldar eldar added the C-bug Category: bug - something isn't working as it's supposed to label May 11, 2024
@eldar eldar changed the title Cannot type in a server in the Remote SSH text box Cannot type in a server name in the Remote SSH text box May 11, 2024
@dzhou121
Copy link
Collaborator

Can you please try to disable "custom titlebar" in settings.

@eldar
Copy link
Author

eldar commented May 12, 2024

I disabled custom title bar, restarted Lapce which made the OS title bar to appear, but I still could not type into the remote SSH text box.

@simoniz0r
Copy link

This is the same as #2857. Certain input boxes do not take focus correctly. If you click on something like the button to collapse Open Editors, you should be able to type in there. Same sort of thing happens for the commit input box, the command palette, and a few other things.

@amrit-citrusleaf
Copy link

Bump. The same issue is happening on macOS 14.3.1.
Not sure but looks like Lapce is unable to read the ~/.ssh/config file.

@panekj
Copy link
Collaborator

panekj commented May 13, 2024

Bump. The same issue is happening on macOS 14.3.1.
Not sure but looks like Lapce is unable to read the ~/.ssh/config file.

Lapce does not read ~/.ssh/config at all, also please don't post comments like that since they ping people unnecessarily

@amrit-citrusleaf
Copy link

@panekj - I tried contributing with the little knowledge I had. I really like Lapce and want it to grow. I will refrain myself from using it further and contributing with my "useless comments". :)
Apologies for "unnecessarily pinging people" 🙏🏼

@eldar
Copy link
Author

eldar commented May 13, 2024

The documentation https://docs.lapce.dev/get-started/remote-development says that Lapce uses ~/.ssh/config. I managed to get the textbox into focus, but I am confused how to specify credentials for a remote server. I have remote servers configured in the said file including proxy jumps - it would be easier to be able to reuse those settings.

@amrit-citrusleaf
Copy link

Bump. The same issue is happening on macOS 14.3.1.
Not sure but looks like Lapce is unable to read the ~/.ssh/config file.

Lapce does not read ~/.ssh/config at all, also please don't post comments like that since they ping people unnecessarily

@panekj - update the documentation if Lapce does not use ~/.ssh/config file. https://docs.lapce.dev/get-started/remote-development

@panekj
Copy link
Collaborator

panekj commented May 13, 2024

The documentation docs.lapce.dev/get-started/remote-development says that Lapce uses ~/.ssh/config.

The documentation states that you can use hostname you configured in ~/.ssh/config. Lapce doesn't use that config, it's not going to show you anything from that file. Lapce will "use" the hostname, because it's invoking ssh command which reads t that file.

I am confused how to specify credentials for a remote server

You can type in palette just the name or <user>@<hostname> to connect

it would be easier to be able to reuse those settings.

It will use SSH config to connect since it's using OpenSSH you have installed on your machine.

@amrit-citrusleaf
Copy link

The documentation docs.lapce.dev/get-started/remote-development says that Lapce uses ~/.ssh/config.

The documentation states that you can use hostname you configured in ~/.ssh/config. Lapce doesn't use that config, it's not going to show you anything from that file. Lapce will "use" the hostname, because it's invoking ssh command which reads t that file.

Got it. So essentially it still "reads" the config file, but only the host name part.
So the real issue is that the host names are not appearing in the UI.

@panekj
Copy link
Collaborator

panekj commented May 13, 2024

So the real issue is that the host names are not appearing in the UI.

There was never any intention for reading SSH config into Lapce or having it display anything more than recent connections (hosts connected to recently), so it's not an issue.
The real issue is that titlebar steals focus from palette input when clicked on.

@panekj
Copy link
Collaborator

panekj commented May 13, 2024

I see that the screenshot in the documentation being right under statement of SSH config, can confuse people as to what exactly is happening and I didn't noticed that mistake, this should be updated shortly.
We also had placeholder value when palette input is empty when using SSH connection, but it got lost in UI refactoring.

panekj added a commit to lapce/lapce-docs that referenced this issue May 13, 2024
@panekj
Copy link
Collaborator

panekj commented May 14, 2024

Duplicate of #2857

@panekj panekj marked this as a duplicate of #2857 May 14, 2024
@panekj panekj closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug - something isn't working as it's supposed to
Projects
None yet
Development

No branches or pull requests

5 participants