Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Disable debug output #1804

Open
Lunik opened this issue Apr 23, 2024 · 4 comments
Open

bug: Disable debug output #1804

Lunik opened this issue Apr 23, 2024 · 4 comments
Labels
bug Something isn't working feat-api

Comments

@Lunik
Copy link

Lunik commented Apr 23, 2024

Describe the bug

As of right now, each time a trace is recorded to Langfuse, a debug log is displayed to the stdout. This is a security issue because it can leak sensitive information (input/ouput completion)

To reproduce

Launch a Languse instance and make a trace with completion

Additional information

A boolean to enable or disable this behaviour should be enought

@hookenful
Copy link

hookenful commented Apr 23, 2024

There is LANGFUSE_DEBUG=false environment variable or callback's param debug=False depends whether you use full SDK or callbacks

@marcklingen
Copy link
Member

to confirm, @Lunik you suggest to toggle this behavior on the langfuse api, not on the sdks as @hookenful suggested?

@marcklingen marcklingen added feat-api bug Something isn't working labels Apr 30, 2024 — with Linear
@tmyjoe
Copy link

tmyjoe commented May 3, 2024

I have also come across the same issue. To illustrate, the log output on this particular line is an example of the concern:

`handling single event ${event.id} ${JSON.stringify(restEvent)}`,

It would be beneficial to introduce a configuration option that toggle this log output ON or OFF.

@tmyjoe
Copy link

tmyjoe commented May 3, 2024

The log has been reduced in 2.37.3, but it seems that the Input is still being outputted in cases where there is no Output yet.
Additionally, a similar problem was found in this location as well:
https://github.com/langfuse/langfuse/blob/v2.37.3/web/src/pages/api/public/traces.ts#L59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat-api
Projects
None yet
Development

No branches or pull requests

4 participants