Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Having a langchain4j-test module with helper classes #1116

Open
agoncal opened this issue May 16, 2024 · 1 comment
Open

[FEATURE] Having a langchain4j-test module with helper classes #1116

agoncal opened this issue May 16, 2024 · 1 comment
Labels
enhancement New feature or request P2 High priority

Comments

@agoncal
Copy link
Contributor

agoncal commented May 16, 2024

Is your feature request related to a problem? Please describe.

Today we have test classes (such as ChatModelMock) that would be helpful to expose so we can use them in our unit/integration tests. It would be nice to have a separate langchain4j-test module that we could use.

Describe the solution you'd like

Have a separate langchain4j-test module, have langchain4j-core depending on it.

@agoncal agoncal added the enhancement New feature or request label May 16, 2024
@agoncal
Copy link
Contributor Author

agoncal commented May 17, 2024

After a quick analysis, ChatModelMock implements ChatLanguageModel. If we move ChatModelMock to a langchain4j-test module it will depend on langchain4j-core module... which will depend on langchain4j-test. This will break because of cyclic dependency.

I'll investigate a bit more

@langchain4j langchain4j added the P2 High priority label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 High priority
Projects
None yet
Development

No branches or pull requests

2 participants