Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] AzureAiSearchEmbeddingStore - add "indexName" to the builder #1062

Closed
vprudnikov opened this issue May 8, 2024 · 2 comments · Fixed by #1084
Closed

[FEATURE] AzureAiSearchEmbeddingStore - add "indexName" to the builder #1062

vprudnikov opened this issue May 8, 2024 · 2 comments · Fixed by #1084
Labels
enhancement New feature or request P2 High priority

Comments

@vprudnikov
Copy link

Is your feature request related to a problem? Please describe.

Currently, it's not possible to override the index name without creating the entire index by yourself.

Describe the solution you'd like

I would like to be able to set the index name using AzureAiSearchEmbeddingStore.builder() like

AzureAiSearchEmbeddingStore.builder()
                .apiKey(properties.apiKey())
                .endpoint(properties.endpoint())
                .indexName(myIndexName)
                .dimensions(DIMENSIONS)
                .build();

or

AzureAiSearchEmbeddingStore.builder()
                .apiKey(properties.apiKey())
                .endpoint(properties.endpoint())
                .indexName(indexBuilder -> indexBuilder.name(myIndexName))
                .dimensions(DIMENSIONS)
                .build();

In other words, it would be great to still rely on the default implementation regarding the index settings however, at the same time, be able to override only the index name.
@vprudnikov vprudnikov added the enhancement New feature or request label May 8, 2024
@langchain4j
Copy link
Owner

cc @jdubois

@langchain4j langchain4j added the P2 High priority label May 8, 2024
jdubois added a commit to jdubois/langchain4j that referenced this issue May 10, 2024
@jdubois
AzureAiSearchEmbeddingStore - add "indexName" to the builder
446fc2b 
Fix langchain4j#1062
@jdubois jdubois mentioned this issue May 10, 2024
Merged
@jdubois
Copy link
Contributor

jdubois commented May 10, 2024

Thanks, the PR is available at #1084

@jdubois jdubois mentioned this issue May 13, 2024
Open
langchain4j pushed a commit that referenced this issue May 22, 2024
@jdubois
AzureAiSearchEmbeddingStore - add "indexName" to the builder (#1084)
495344e 
Fix #1062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P2 High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AzureAiSearchEmbeddingStore - add "indexName" to the builder jdubois/langchain4j
3 participants
@jdubois @vprudnikov @langchain4j