Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I hope you can upgrade the iredis dependency click version to 8 #427

Open
ponponon opened this issue Jun 21, 2022 · 5 comments
Open

I hope you can upgrade the iredis dependency click version to 8 #427

ponponon opened this issue Jun 21, 2022 · 5 comments

Comments

@ponponon
Copy link

But when I tried to install iredis, I found a conflict between flask and the version of click on which iredis depends

pip install iredis

error info 👇

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
flask 2.1.2 requires click>=8.0, but you have click 7.1.2 which is incompatible.

flask version info 👇

─➤  pip show flask    
Name: Flask
Version: 2.1.2
Summary: A simple framework for building complex web applications.
Home-page: https://palletsprojects.com/p/flask
Author: Armin Ronacher
Author-email: armin.ronacher@active-4.com
License: BSD-3-Clause
Location: /Users/ponponon/.local/share/virtualenvs/ideaboom-B0dr_aXc/lib/python3.10/site-packages
Requires: click, itsdangerous, Jinja2, Werkzeug
Required-by: 
@laixintao
Copy link
Owner

sure, why not.

@laixintao
Copy link
Owner

oh Click dropped Python3.6 support, since IRedis is still supporting 3.6, I think I need more time to upgrade.

https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0

@ponponon
Copy link
Author

oh Click 放弃了对 Python3.6 的支持,因为 IRedis 仍然支持 3.6,我想我需要更多的时间来升级。

https://click.palletsprojects.com/en/8.1.x/changes/#version-8-1-0

Yes, because click supports type annotations in 8.0, which requires python 3.7+

I think type annotations are a great effect that can help us improve the dynamic language refactoring crematorium

@laixintao
Copy link
Owner

Yes understand. I mean I may need more time to drop the support for Python3.6

@Lotram
Copy link
Contributor

Lotram commented Sep 29, 2023

Hello, any news on this issue ? I'd also like to use click v8 along iredis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants