Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart: Creating extraManifests on Helm Chart #11370

Closed
wants to merge 1 commit into from
Closed

Chart: Creating extraManifests on Helm Chart #11370

wants to merge 1 commit into from

Conversation

msfidelis
Copy link
Contributor

@msfidelis msfidelis commented May 17, 2024 •
edited

What this PR does / why we need it:

I'm sending this Pull Request to address the Issue that mentions the helm chart's ability to create extra manifests on demand. I think the issue may require a bit more screening, but I'm putting the work in progress to discuss.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #11351

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority labels May 17, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @msfidelis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2024
@msfidelis msfidelis marked this pull request as draft May 17, 2024 10:43
@netlify Netlify
Copy link

netlify bot commented May 17, 2024 •
edited

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 57fd73e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/6647d9a02c86c20008fe2685

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: msfidelis
Once this PR has been reviewed and has the lgtm label, please assign ubergesundheit for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from Gacko May 17, 2024 10:43
@k8s-ci-robot k8s-ci-robot added the area/helm Issues or PRs related to helm charts label May 17, 2024
@msfidelis
feature(extra_manifests): initial work
57fd73e 
fix(chart): lint

fix(chart): typo

fix(chart): typo

fix(chart): template rendering

fix(chart): template rendering

fix(chart): helm chart test

fix(chart): helm chart test

fix(chart): helm chart test name
@msfidelis msfidelis force-pushed the feature/helm_extra_manifest branch from 3164f4d to 57fd73e Compare May 17, 2024 22:26
@msfidelis msfidelis marked this pull request as ready for review May 17, 2024 22:34
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2024
@Gacko
Copy link
Member

Gacko commented May 23, 2024

I cannot recall where, but we already had requests like that in the past and decided not to support them as they bring extra complexity to the chart which should be covered by user's tooling. Anything could be put into that value and users will come up with issues and asking for our support just because we are offering this possibility. It's basically adding a wildcard to add any kind of manifest, even those we do not know yet, and users will ask us to extend that feature to a point where we cannot support it anymore. It's already complicated enough to support manifests not directly related to how Ingress NGINX works right now.

I'm closing both this PR and the issue now.

@Gacko
Copy link
Member

Gacko commented May 23, 2024

/close

@k8s-ci-robot
Copy link
Contributor

@Gacko: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member

Gacko commented May 23, 2024

Ah, yeah, here we go. This is the other PR: #10945

@msfidelis
Copy link
Contributor Author

I understand you point @Gacko , thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Awaiting requested review from Gacko

@ubergesundheit ubergesundheit Awaiting requested review from ubergesundheit

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees
No one assigned
Labels
area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow the Chart to create extra manifest
3 participants
@msfidelis @k8s-ci-robot @Gacko