Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the addresses array in Knative Serving #15210

Open
Leo6Leo opened this issue May 15, 2024 · 1 comment
Open

Using the addresses array in Knative Serving #15210

Leo6Leo opened this issue May 15, 2024 · 1 comment
Labels
area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding.

Comments

@Leo6Leo
Copy link
Member

Leo6Leo commented May 15, 2024

Describe the feature

Context: please see the discussion in this issue knative/eventing#7875

Using the addresses array in Knative Serving.

/area API

@Leo6Leo Leo6Leo added the kind/feature Well-understood/specified features, ready for coding. label May 15, 2024
@knative-prow knative-prow bot added the area/API API objects and controllers label May 15, 2024
@ReToCode
Copy link
Member

I'm not sure I understand what is asked here. In Serving status you can already find the public and the cluster local domain:

- apiVersion: serving.knative.dev/v1
  kind: Service
  spec:
  status:
    address:
      url: http://sklearn-v2-iris-predictor.kserve-model.svc.cluster.local/

    observedGeneration: 1
    traffic:
      - latestRevision: true
        percent: 100
        revisionName: sklearn-v2-iris-predictor-00001
    url: https://sklearn-v2-iris-predictor-kserve-model.apps.sno.codemint.ch/

Is this not sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Development

No branches or pull requests

2 participants