Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Inputs not NULL after typing in them/removing characters #3768

Closed
japerry911 opened this issue May 18, 2024 · 5 comments · Fixed by #3780
Closed

Empty Inputs not NULL after typing in them/removing characters #3768

japerry911 opened this issue May 18, 2024 · 5 comments · Fixed by #3780
Assignees
Labels
bug Something isn't working frontend Need some frontend code changes quick-win up to 2h
Milestone

Comments

@japerry911
Copy link

Describe the issue

I have a STRING type input, Property IDs.
It defaults to NULL since I have required: false , but if I accidentally type in it, and delete what I type, it ends up going through as an empty string "".
I was curious, is there a way to make it NULL instead of empty string when you revert what's inputted? My use case is I use Pebble expression to remove --property_ids <property_ids_input from a Python script call if Property IDs is NULL. I could always remove if NULL or empty string, but I wanted to check before doing that.
let me know if you need more details in responding to this, appreciate the help, thank you

Images:
1st image shows input as it appears after I delete text that accidentally inputted
2nd image shows input in execution overview tab showing Blank string and not NULL

Screenshot 2024-05-17 at 1 22 12 PM

Screenshot 2024-05-17 at 1 25 04 PM

Environment

  • Kestra Version: v0.16.6
  • Operating System (OS/Docker/Kubernetes): GCP VM Docker Compose
  • Java Version (if you don't run kestra in Docker): n/a
@japerry911 japerry911 added the bug Something isn't working label May 18, 2024
@anna-geller
Copy link
Member

You can close the window and reopening again will no longer have that empty string;)

Alternatively, what if you explicitly type null without any quotes? AFK so hard to check atm

@japerry911
Copy link
Author

I'll test typing 'null' when I get back.

I was thinking there could be a little null button or something like the checkboxes have above input box or something. I'll elaborate when I get on later.

Thanks @anna-geller !

@japerry911
Copy link
Author

Alternatively, what if you explicitly type null without any quotes?

This does not work, does "null" as string.

I was envisioning something like this, where you could press None, or String and if String it gives input box.

Screenshot 2024-05-18 at 1 37 38 PM

*This is not blocking anything for me, so nothing urgently needs to be done on it, just noticed it when I was 'deving' and rerunning runs frequently.

@loicmathieu
Copy link
Member

@anna-geller it's not a bug and providing a specific UI for such thing may be a bit overkilled. Let's move this to 0.18 to have more time to think about it.

@loicmathieu loicmathieu added quick-win up to 2h frontend Need some frontend code changes enhancement New feature or request labels May 20, 2024
@tchiotludo tchiotludo modified the milestones: v0.18.0, v0.17.0 May 20, 2024
@loicmathieu loicmathieu added bug Something isn't working and removed enhancement New feature or request labels May 21, 2024
@anna-geller
Copy link
Member

anna-geller commented May 21, 2024

we discussed together that an input should never be an empty string so we'll replace the empty string input values with null on the UI-side — @MilosPaunovic ping me if you want more details/examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Need some frontend code changes quick-win up to 2h
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants