Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Decrypt button of the SSH agent never activates. #10637

Closed
AlexpFr opened this issue Apr 28, 2024 · 0 comments · Fixed by #10638
Closed

The Decrypt button of the SSH agent never activates. #10637

AlexpFr opened this issue Apr 28, 2024 · 0 comments · Fixed by #10638
Labels
bug

Comments

@AlexpFr
Copy link
Contributor

AlexpFr commented Apr 28, 2024 •
edited

The reason is that the activation condition is: if (!key.comment().isEmpty() || !key.encrypted()).
But the comment is never empty because when opening the key we have:

if (key.comment().isEmpty() && !key.encrypted()) {
    key.setComment(username);
}

if (key.comment().isEmpty() && !key.encrypted()) {
    key.setComment(fileName);
}

I made a fix, I am preparing a PR.
@AlexpFr AlexpFr added the bug label Apr 28, 2024
AlexpFr added a commit to AlexpFr/keepassxc that referenced this issue Apr 28, 2024
@AlexpFr
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
3da116d
@AlexpFr AlexpFr mentioned this issue Apr 28, 2024
Merged
AlexpFr added a commit to AlexpFr/keepassxc that referenced this issue Apr 28, 2024
@AlexpFr
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
c1701e9
AlexpFr added a commit to AlexpFr/keepassxc that referenced this issue Apr 29, 2024
@AlexpFr
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
cd9077e
AlexpFr added a commit to AlexpFr/keepassxc that referenced this issue May 1, 2024
@AlexpFr
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
52d113b
AlexpFr added a commit to AlexpFr/keepassxc that referenced this issue May 5, 2024
@AlexpFr
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
68c853c
AlexpFr added a commit to AlexpFr/keepassxc that referenced this issue May 5, 2024
@AlexpFr
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
e00059d
AlexpFr added a commit to AlexpFr/keepassxc that referenced this issue May 5, 2024
@AlexpFr
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
237b0cc
AlexpFr added a commit to AlexpFr/keepassxc that referenced this issue May 5, 2024
@AlexpFr
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
badabd3
AlexpFr added a commit to AlexpFr/keepassxc that referenced this issue May 5, 2024
@AlexpFr
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
d4f07df
AlexpFr added a commit to AlexpFr/keepassxc that referenced this issue May 7, 2024
@AlexpFr
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
99c964e
AlexpFr added a commit to AlexpFr/keepassxc that referenced this issue May 12, 2024
@AlexpFr
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
c47108a
droidmonkey pushed a commit to AlexpFr/keepassxc that referenced this issue May 26, 2024
@AlexpFr @droidmonkey
SSH Agent: Fix broken decrypt button (keepassxreboot#10637)
8e127cb
droidmonkey added a commit that referenced this issue May 27, 2024
@AlexpFr @droidmonkey
Fix SSH Agent broken decrypt button (#10638)
8cd45f5 
* SSH Agent: Fix broken decrypt button (Fixes #10637)

---------

Co-authored-by: Jonathan White <support@dmapps.us>
pull bot pushed a commit to shashinma/keepassxc that referenced this issue May 28, 2024
@AlexpFr @droidmonkey @pull
Fix SSH Agent broken decrypt button (keepassxreboot#10638)
737d4d4 
* SSH Agent: Fix broken decrypt button (Fixes keepassxreboot#10637)

---------

Co-authored-by: Jonathan White <support@dmapps.us>
droidmonkey added a commit that referenced this issue Jun 2, 2024
@droidmonkey
Fix SSH Agent broken decrypt button (#10638)
1b3abf8 
* SSH Agent: Fix broken decrypt button (Fixes #10637)

---------

Co-authored-by: Jonathan White <support@dmapps.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SSH Agent broken decrypt button AlexpFr/keepassxc
1 participant
@AlexpFr