Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Scalers with new declarative scaler config #5797

Open
2 of 59 tasks
dttung2905 opened this issue May 13, 2024 · 3 comments
Open
2 of 59 tasks

Refactor Scalers with new declarative scaler config #5797

dttung2905 opened this issue May 13, 2024 · 3 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@dttung2905
Copy link
Contributor

dttung2905 commented May 13, 2024

Proposal

We can take turn implement the changes in this PR #5676. This is related to the original issue here #5037. I can take the kafka one since I have been working on something similar in #5319

  • activemq_scaler.go Refactor ActiveMQ scaler config #5799
  • apache_kafka_scaler.go Refactor Apache Kafka scaler config #5804
  • arangodb_scaler.go Refactor arangodb scaler config #5808
  • artemis_scaler.go Refactor Artemis scaler config #5836
  • aws_cloudwatch_scaler.go Refactor aws cloudwatch scaler #5852
  • aws_dynamodb_scaler.go
  • aws_dynamodb_streams_scaler.go
  • aws_kinesis_stream_scaler.go
  • aws_sqs_queue_scaler.go
  • azure_app_insights_scaler.go
  • azure_blob_scaler.go
  • azure_data_explorer_scaler.go
  • azure_eventhub_scaler.go
  • azure_log_analytics_scaler.go
  • azure_monitor_scaler.go
  • azure_pipelines_scaler.go
  • azure_queue_scaler.go
  • azure_servicebus_scaler.go
  • cassandra_scaler.go
  • couchdb_scaler.go
  • cpu_memory_scaler.go
  • cron_scaler.go
  • datadog_scaler.go
  • elasticsearch_scaler.go
  • etcd_scaler.go
  • external_mock_scaler.go
  • external_scaler.go
  • gcp_cloud_tasks_scaler.go
  • gcp_pubsub_scaler.go
  • gcp_stackdriver_scaler.go
  • gcp_storage_scaler.go
  • github_runner_scaler.go
  • graphite_scaler.go
  • huawei_cloudeye_scaler.go
  • ibmmq_scaler.go
  • influxdb_scaler.go
  • kafka_scaler.go
  • kubernetes_workload_scaler.go
  • liiklus_scaler.go
  • loki_scaler.go
  • metrics_api_scaler.go
  • mongo_scaler.go
  • mssql_scaler.go
  • mysql_scaler.go
  • nats_jetstream_scaler.go
  • newrelic_scaler.go
  • openstack_metrics_scaler.go
  • openstack_swift_scaler.go
  • postgresql_scaler.go
  • predictkube_scaler.go
  • prometheus_scaler.go
  • pulsar_scaler.go
  • rabbitmq_scaler.go
  • redis_scaler.go
  • redis_streams_scaler.go
  • selenium_grid_scaler.go
  • solace_scaler.go
  • solr_scaler.go WIP: Refactor solr scaler config  #5818
  • stan_scaler.go

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

@dttung2905 dttung2905 added feature-request All issues for new features that have not been committed to needs-discussion labels May 13, 2024
@SpiritZhou
Copy link
Contributor

I can help to do some of them.

@dttung2905
Copy link
Contributor Author

Sure. Me and @wozniakjan is doing from top down. May be you want to try doing from bottom up?

@wozniakjan
Copy link
Member

fyi @SpiritZhou, @dttung2905 no need to introduce changelog entry for each PR, it will be mentioned in one place - #5799 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
None yet
Development

No branches or pull requests

3 participants