Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script INSTALL_K3S_PR support does not work if CI has run more than once #10116

Open
brandond opened this issue May 16, 2024 · 2 comments
Assignees
Milestone

Comments

@brandond
Copy link
Contributor

brandond commented May 16, 2024

If the action runs multiple times (say due to being restarted to address a flake), the RUN_ID expression may return multiple results:

k3s/install.sh

Lines 496 to 497 in 1d22b69

# Extract the Run ID from the build workflow and lookup artifacts associated with the run
RUN_ID=$(echo "$build_workflow" | jq -r ' .details_url' | awk -F'/' '{print $(NF-2)}')

#8 1.395 + RUN_ID='9118227575
#8 1.395 9118227594'
#8 1.396 ++ curl -s -H 'Authorization: Bearer xxx' 'https://api.github.com/repos/k3s-io/k3s/actions/runs/9118227575
#8 1.396 9118227594/artifacts'
#8 1.402 + artifacts=
@brandond
Copy link
Contributor Author

cc @dereknola

@brandond
Copy link
Contributor Author

no backports, since install script changes only go to master

@brandond brandond modified the milestones: Backlog, v1.30.2+k3s1 May 23, 2024
@ShylajaDevadiga ShylajaDevadiga self-assigned this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Test
Development

No branches or pull requests

3 participants