You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The helm-controller refactor in in k3s-io/helm-controller#157 added a WithSetOwnerReference(false, false) to the desiredset/apply controller, but that was missed when we pulled in the refactor into k3s in #6294.
As a result, the helm controller has been failing to properly track resource ownership, and owned objects are sometimes orphaned instead of being properly deleted.
The text was updated successfully, but these errors were encountered:
brandond
changed the title
Helm-controller does not track owner references properly
Embedded helm controller does not track owner references properly
Apr 30, 2024
@huangzynn do you have any specific steps to reproduce incorrect behavior that this omission was causing? While the fix is technically correct, I am not aware of any easy-to-reproduce problems that this fixes, which makes it hard for our QA team to validate a fix.
in both versions am testing we do have the
ownerReferences:
- apiVersion: apps/v1
blockOwnerDeletion: true
controller: true
kind: ReplicaSet
name: mynginx-5d8b585d74
uid: 180b0817-7926-41d1-95b8-21d13219ce2f
resourceVersion: "881"
The helm-controller refactor in in k3s-io/helm-controller#157 added a
WithSetOwnerReference(false, false)
to the desiredset/apply controller, but that was missed when we pulled in the refactor into k3s in #6294.As a result, the helm controller has been failing to properly track resource ownership, and owned objects are sometimes orphaned instead of being properly deleted.
The text was updated successfully, but these errors were encountered: