Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded helm controller does not track owner references properly #10051

Closed
brandond opened this issue Apr 30, 2024 · 3 comments
Closed

Embedded helm controller does not track owner references properly #10051

brandond opened this issue Apr 30, 2024 · 3 comments
Assignees
Milestone

Comments

@brandond
Copy link
Contributor

The helm-controller refactor in in k3s-io/helm-controller#157 added a WithSetOwnerReference(false, false) to the desiredset/apply controller, but that was missed when we pulled in the refactor into k3s in #6294.

As a result, the helm controller has been failing to properly track resource ownership, and owned objects are sometimes orphaned instead of being properly deleted.

@brandond
Copy link
Contributor Author

brandond commented Jun 4, 2024

@huangzynn do you have any specific steps to reproduce incorrect behavior that this omission was causing? While the fix is technically correct, I am not aware of any easy-to-reproduce problems that this fixes, which makes it hard for our QA team to validate a fix.

@fmoral2
Copy link
Contributor

fmoral2 commented Jun 4, 2024

@huangzynn any thoughts here ?

@fmoral2
Copy link
Contributor

fmoral2 commented Jun 6, 2024

Trying to replicate the issue with no success

always getting

in both versions am testing we do have the
  ownerReferences:
  - apiVersion: apps/v1
    blockOwnerDeletion: true
    controller: true
    kind: ReplicaSet
    name: mynginx-5d8b585d74
    uid: 180b0817-7926-41d1-95b8-21d13219ce2f
  resourceVersion: "881"

and no deletion jobs or orphans left behind.

@fmoral2 fmoral2 closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done Issue
Development

No branches or pull requests

3 participants