Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%XVEGA_PLOT and sql statement on new line: <> needs a space after to make it work #36

Open
jankatins opened this issue Feb 16, 2021 · 2 comments
Labels
C++ good first issue Good for newcomers

Comments

@jankatins
Copy link

jankatins commented Feb 16, 2021

Currently, putting the select statement on the next line is a bit strange. e.g. neither of the following two cells work:

%XVEGA_PLOT X_FIELD x Y_FIELD y MARK line COLOR purple WIDTH 400 HEIGHT 200 <>
Select *
FROM (VALUES (1,1), (2,2)) t(x,y)
%XVEGA_PLOT X_FIELD x Y_FIELD y MARK line COLOR purple WIDTH 400 HEIGHT 200
Select *
FROM (VALUES (1,1), (2,2)) t(x,y)

Error both times: Error: cannot create std::vector larger than max_size()

Funnily, this works:

%XVEGA_PLOT X_FIELD x Y_FIELD y MARK line COLOR purple WIDTH 400 HEIGHT 200 <> 
Select *
FROM (VALUES (1,1), (2,2)) t(x,y)

-> Difference: a space after <>...

@marimeireles
Copy link
Member

Ah, this a linting problem for sure... Shouldn't be too hard to fix it. The culprit will probably be in the xvega_bindings repo. Currently can't work on this but I can provide guidance for people interested in tackling it.
Thanks for the issue @jankatins !

@marimeireles marimeireles added good first issue Good for newcomers C++ labels Mar 9, 2021
@marimeireles
Copy link
Member

Probably worth to take a look in the changes mentioned here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants