Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link thumbnails not working #619

Open
Sbrjt opened this issue Jul 2, 2023 · 7 comments · May be fixed by #666
Open

Link thumbnails not working #619

Sbrjt opened this issue Jul 2, 2023 · 7 comments · May be fixed by #666

Comments

@Sbrjt
Copy link

Sbrjt commented Jul 2, 2023

The link thumbnails for https://chat.openai.com and https://web.whatsapp.com are not working (display as ▶)

Screenshot (72)

Is it the case with everyone?

@theerfan
Copy link

Quick question, @Sbrjt, how did you add the other urls with their proper thumbnail?

@Sbrjt
Copy link
Author

Sbrjt commented Jul 20, 2023

In icons, there's a website icon option. @theerfan

See

@theerfan
Copy link

Yeah, weirdly enough that never works for me.

@Sbrjt
Copy link
Author

Sbrjt commented Jul 26, 2023

@theerfan Does it work after importing my settings?

tabliss.json
(Please change file name to tabliss.json as github didn't allow me to upload json)

@theerfan
Copy link

theerfan commented Aug 2, 2023

Yeah it did, thank you so much!

@KayeAye
Copy link

KayeAye commented Nov 5, 2023

Just had the same problem. Tabliss uses duckduckgo's icon service to retrieve the icons and it appears duckduckgo's copy of the icon is corrupted. I managed a workaround by using css that directly grabs the icon, this does undermine the point of using duckduckgo to grab the icons anonymously though. Here's the CSS for the scispace one (typeset.io). "Alt" was found by inspecting element (it's just the url). The padding is the same as the font size you see for that quick link's .widget div (I believe this is what is controlled by the 'size' slider in the display settings).

img[alt="typeset.io"] {
	font-size:0;
	padding: 18px 18px 0 0;
	background: url('https://scispace.com/static/favicon.svg');
	background-size:cover;
}

Edit: The problem with chatgpt (your issue) is actually that duckduckgo still has the default icon in place for the chat.openai.com subdomain. You can use https://icons.duckduckgo.com/ip3/openai.com.ico as the background image url and still avoid directly grabbing the icon from openai

@Sbrjt
Copy link
Author

Sbrjt commented Feb 16, 2024

Yeah. duckduckgo's favicon grabber is not working for links with subdomains: https://icons.duckduckgo.com/ip3/https://chat.openai.com

Google's utility is working tho: https://www.google.com/s2/favicons?sz=32&domain_url=https://chat.openai.com.

(in Display.tsx)

@joelshepherd

@Sbrjt Sbrjt linked a pull request Feb 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants