Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can AdapterMan support E-commerce Opencart 4? #34

Open
FelipoAntonoff opened this issue Apr 21, 2023 · 2 comments
Open

Can AdapterMan support E-commerce Opencart 4? #34

FelipoAntonoff opened this issue Apr 21, 2023 · 2 comments
Labels
question Further information is requested

Comments

@FelipoAntonoff
Copy link

Can it support E-commerce Opencart 4?

Github: https://github.com/opencart/opencart
It basically has a micro framework built natively for it and a lot of use of pure PHP, SSL and more direct session.

Uses an index.php to launch: https://github.com/opencart/opencart/blob/master/upload/index.php
Which calls the framework.php and startup.php in system https://github.com/opencart/opencart/tree/master/upload/system

It should probably pick up I imagine making adjustments to index.php .

@joanhey
Copy link
Owner

joanhey commented Apr 27, 2023

In theory will work, but perhaps with changes.

The first thing is remove all the exit() in the code, as this will close all the app.
I can't change the behavior of exit(), because is a language constructor and not a function.
The best solution is use an ExitExeption : https://github.com/joanhey/AdapterMan/blob/master/src/AdapterFunctions.php#L208-L211

@FelipoAntonoff
Copy link
Author

Thanks for the answer.
In this case, perhaps a small reformulation of the code should solve it, too bad that some modules/plugins can use exit() and thus cause an error, but for a specific project, the adaptation may be well suited if high demand is needed.

@joanhey joanhey added the question Further information is requested label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants