Don't set content type to null for mixed libraries during creation #5496
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cloudflare Pages deployment
|
|
This will definitely break other functionality (in web) that depends on the mixed type being undefined. |
Would it be better then to change code that checks for mixed type to check for undefined type? Seems to just be a few places in the library scripts. As long as it's guaranteed that an undefined type always means mixed movies and shows then that should also work. |
|
I haven't had a chance to read over the related issue fully but we need to ensure that existing libraries with the undefined type continue to work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed code that set content type to null for mixed libraries during virtual folder creation.
This was added in 81d936f. There is no further information about what issue this fixed, however it is currently causing issues for parts of code that expect the content type to be correctly set.
I was not able to find any issues when creating a mixed library, viewing mixed library content, etc. after making this change but so much of the code has changed since 2015 it's hard to say if whatever issue that prompted this change has been fixed somewhere else or if it is just not obvious enough to find during preliminary testing.
Alternatively, code that checks for 'mixed' type could instead check for null.
Issues
Fixes #5490
Fixes jellyfin/jellyfin#11284
Also fixes related issues such as library sub-heading showing "Other" instead of "Mixed Movies and Shows."