Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting bukuserver API #637

Open
LeXofLeviafan opened this issue Dec 7, 2022 · 7 comments
Open

Documenting bukuserver API #637

LeXofLeviafan opened this issue Dec 7, 2022 · 7 comments

Comments

@LeXofLeviafan
Copy link
Collaborator

The startup bukuserver code sets up a handful of /api routes; as far as I can tell, only /api/tags is actually used within the app. Are the rest of these endpoints legacy code, or are they meant for external usage? I reckon the API should either be cleaned up or documented (it doesn't even seem to be mentioned in readme at the moment).

@rachmadaniHaryono
Copy link
Collaborator

They are meant for external usage

They are actually the main reason for bukuserver development

Maybe because there's no doc there's also no one want to develop program with it

@LeXofLeviafan
Copy link
Collaborator Author

Maybe because there's no doc there's also no one want to develop program with it

That does sound like a defining factor, yes 😄

Even in the main buku readme, bukuserver is only ever referred to as a GUI – there's no mention of a web-API anywhere.

@rachmadaniHaryono
Copy link
Collaborator

So basically

  • edit the doc to mention bukuserver web api
  • have better doc on api ,open api https://www.openapis.org/, maybe add screenshot
  • ask if any developer interested on api in next release

@LeXofLeviafan LeXofLeviafan changed the title The status of bukuserver API Documenting bukuserver API Dec 7, 2022
@LeXofLeviafan
Copy link
Collaborator Author

…Might also be a good idea to move the API MethodViews into a separate file.

@rachmadaniHaryono
Copy link
Collaborator

at first i want to put that on lower priority

but organized api code will make life easier for docs writer and developer, so maybe yes

@2ynn
Copy link
Contributor

2ynn commented Feb 6, 2023

Hi, I'd be interested in working on this. Would you be open to set up SwaggerUI?
e.g.
https://github.com/sveint/flask-swagger-ui
https://github.com/flasgger/flasgger
https://github.com/overflowdigital/Flask-OpenAPI

@LeXofLeviafan
Copy link
Collaborator Author

That sounds like a good idea to me. Though, a static (if brief) description in bukuserver readme would still be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants