Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Consider adding a conda environment.yml file and containerizing it using Docker #15

Closed
kourouklides opened this issue Feb 5, 2024 · 1 comment

Comments

@kourouklides
Copy link

kourouklides commented Feb 5, 2024

Hey there,

Thank you for helping us to set up your chatbot on our Discord server. It's awesome! Very good job. I am also very glad that you started having traction. I am also trying to spread the word myself.

I would like to suggest the following:

  • Adding a conda environment.yml file (or a similar virtual environment file)
  • Adding a Dockerfile to use a Docker container

Both are good practises, because they ensure that other people who install it do not get the "but it works on my computer" problem.

For example, how would someone know what version of Python he should be using to install this? Also, what version of pip should he be using? Yes, you could write it in your README file, but that's suboptimal. A virtual environment like conda helps eliminate or at least mitigate this problem.

Here's an example of an environmenl.yml from one of my repositories (using Apache License 2.0). I am not saying that it's the best, but it should be good enough to get you started:

Happy to talk more about it over Discord, if you wish. 🙂

@jakobdylanc
Copy link
Owner

Closing finally as I've decided to keep the repo Docker-free :-)

@jakobdylanc jakobdylanc closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants