Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istioctl fancy icons may not render on all terminals #51111

Open
ilrudie opened this issue May 16, 2024 · 0 comments
Open

istioctl fancy icons may not render on all terminals #51111

ilrudie opened this issue May 16, 2024 · 0 comments
Labels
Milestone

Comments

@ilrudie
Copy link
Contributor

ilrudie commented May 16, 2024

fix or revert #50744 so that reported issues don't make it into 1.23

proposed fix would be to revert back to the original success/fail characters and decorate the end of each line with a fancy trailing emoji so that if the character isn't present in a user's font they are still able to tell what happened. This seems more reliable than making some sort of attempt to determine what font is being used and then attempting to figure out if that font contains all the characters we're going to use.

@ilrudie ilrudie added this to the 1.23 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant