Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/image: Image pull and export/import command does validate if the artifact is gadget image #2788

Open
mqasimsarfraz opened this issue Apr 30, 2024 · 0 comments

Comments

@mqasimsarfraz
Copy link
Member

          Good question. The same happens for the pull command
$ sudo -E ig image pull docker.io/busybox
INFO[0000] Experimental features enabled
Pulling docker.io/busybox...
Successfully pulled docker.io/library/busybox:latest@sha256:c3839dd800b9eb7603340509769c43e146a74c63dca3045a8e7dc8ee07e53966

$ sudo -E ig image list
INFO[0000] Experimental features enabled
REPOSITORY                                TAG                                      DIGEST       CREATED
docker.io/library/busybox                 latest                                   c3839dd800b9

The OCI logic doesn't check if the image being pulled / imported is actually a gadget image. (It'll require to check the layers of the image and so on). I think it's fine for now.

Originally posted by @mauriciovasquezbernal in #2779 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant