You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using kubectl gadget undeploy the namespace is getting removed
Impact
Different configurations and other things that might live in the same namespace will get removed.
For example PR #2675 introduces image verification. After a deploy one has to remember to add the label back to the namespace. This can be easily overseen
Ideal future situation
kubectl gadget undeploy --leave-namespace removes everything IG related, but keeps the namespace
Implementation options
Add the flag
The text was updated successfully, but these errors were encountered:
I see two options here to avoid adding a new flag.
Add a label to the gadget namespace in deploy, so it's only removed if it was created by Inspektor Gadget. This will require to implement manual logic to remove the things (daemonset, etc...) inside the namespace without removing the namespace
Don't do anything, if the user wants to keep the namespace, then they'll have to deploy IG directly from the manifest and handle it it by themselves.
I'm more leaned towards the second option, I don't think we should be complicating our logic to support a lot of corner cases.
Current situation
When using
kubectl gadget undeploy
the namespace is getting removedImpact
Different configurations and other things that might live in the same namespace will get removed.
For example PR #2675 introduces image verification. After a deploy one has to remember to add the label back to the namespace. This can be easily overseen
Ideal future situation
kubectl gadget undeploy --leave-namespace
removes everything IG related, but keeps the namespaceImplementation options
Add the flag
The text was updated successfully, but these errors were encountered: