Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFE] Create integration tests to validate gadget OCI image #2577

Open
blanquicet opened this issue Mar 5, 2024 · 3 comments
Open

[RFE] Create integration tests to validate gadget OCI image #2577

blanquicet opened this issue Mar 5, 2024 · 3 comments
Labels
lifecycle/staleproof Avoid this issue / PR being marked as stale by the bot.

Comments

@blanquicet
Copy link
Member

blanquicet commented Mar 5, 2024 •
edited

Current situation

Create integration tests in the CI to validate that gadget OCI images generated with ig image build command are compliant with what is defined in the design document. For instance, the first manifest is an index, etc.

Impact

Issues like #2572 / #2289 should be detected by tests.
@blanquicet blanquicet mentioned this issue Mar 5, 2024
Merged
@alban
Copy link
Member

alban commented Mar 5, 2024 •
edited

Do you mean that some of our commands (ig run, ig image build or ig image push) should test that? Or some new command like ig image validate?

Or do you mean CI tests for the image-based gadgets that are implemented in the main inspektor-gadget git repository?

@blanquicet
Copy link
Member Author

I mean CI tests. Sorry for the poor description.

@blanquicet blanquicet changed the title [RFE] Create tests to validate gadget OCI image [RFE] Create integration tests to validate gadget OCI image Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.

@github-actions github-actions bot added the lifecycle/stale Marked to be closed in next 14 days because of inactivity. label May 5, 2024
@blanquicet blanquicet added lifecycle/staleproof Avoid this issue / PR being marked as stale by the bot. and removed lifecycle/stale Marked to be closed in next 14 days because of inactivity. labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/staleproof Avoid this issue / PR being marked as stale by the bot.
Projects
Planning
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alban @blanquicet