Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flatpak package #315

Open
sigmaSd opened this issue Oct 29, 2023 · 8 comments
Open

Add a flatpak package #315

sigmaSd opened this issue Oct 29, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@sigmaSd
Copy link
Collaborator

sigmaSd commented Oct 29, 2023

I was not a recommender of flatpak, but recently I've been using fedora, and through gnome software I keep discovering really cool projects.

I think creating a fltapk have 2 major benefits:

  • It can be published to flathub and it will be become discoverable in stores like gnome software of flathub it self
  • It removes the need to use sudo, and enter password, because we can package a policy kit rule with it ?

with the other benefits of working on more distributions not worrying about older libraries etc

If this is desirable, https://github.com/flathub/com.helix_editor.Helix/blob/master/com.helix_editor.Helix.yml is a good starting place

@sigmaSd sigmaSd changed the title Add a flatpak pakage Add a flatpak package Oct 29, 2023
@cyqsimon
Copy link
Collaborator

To be honest, I have zero experience with Flatpak packaging. I'm not opposed to the idea though - although I personally don't use Flatpak, I can well understand its appeal.

TBH I'm a bit intoxicated at the moment of this reply, so I am not able to make any commitments. There is one thing I would like to ask though: would you @sigmaSd like to be added as a collaborator? That would add a bit more resilience to this project (I'm perfectly okay if your reply is no, so please don't feel pressured).

@sigmaSd
Copy link
Collaborator Author

sigmaSd commented Oct 29, 2023

Thanks @cyqsimon that would be great, I currently can't allocate much time, but I can see myself helping with smaller things and I guess its not bad to have another pair of eyes for PRs issues etc.

Also I'll give this issue a try, shouldn't be that hard (hopefully)

Get Well soon!

@sigmaSd sigmaSd mentioned this issue Oct 29, 2023
@sigmaSd
Copy link
Collaborator Author

sigmaSd commented Oct 30, 2023

Unfortunately this doesn't seem feasible because the flatpak sandbox doesn't allow listening to the network privileges (the ones set with setcap)
More info here flathub/org.wireshark.Wireshark#4

@sigmaSd sigmaSd closed this as completed Oct 30, 2023
@sigmaSd sigmaSd closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
@cyqsimon
Copy link
Collaborator

Thanks @cyqsimon that would be great, I currently can't allocate much time, but I can see myself helping with smaller things and I guess its not bad to have another pair of eyes for PRs issues etc.

@imsnif can you please make @sigmaSd a collaborator? They've been contributing to this repo for far longer than I have been, and are more than qualified for this job. I would love to have more hands on deck. Thanks in advance.

@imsnif
Copy link
Owner

imsnif commented Oct 31, 2023

Done

@sigmaSd
Copy link
Collaborator Author

sigmaSd commented Oct 31, 2023

Thanks appreciated

@sigmaSd
Copy link
Collaborator Author

sigmaSd commented Feb 10, 2024

Flatpak package is possible , if the app is separated to a frontend and a privileged backed (this issue basically #76)

the flatpak package would do:

  • copy the backend to XDG_DATA_DIR (accessible from faltapk)
  • use flatpak-spawn --host pkexec backend

there are some packages in flathub that use flatpak-spawn --host pkexec like https://gitlab.gnome.org/World/bustle/

@cyqsimon
Copy link
Collaborator

Flatpak package is possible , if the app is separated to a frontend and a privileged backed (this issue basically #76)

the flatpak package would do:

  • copy the backend to XDG_DATA_DIR (accessible from faltapk)
  • use flatpak-spawn --host pkexec backend

there are some packages in flathub that use flatpak-spawn --host pkexec like https://gitlab.gnome.org/World/bustle/

Sounds reasonable, but we probably should do this once I complete the rewrite (which is still WIP on my local machine).

I will reopen this for the time being.

@cyqsimon cyqsimon reopened this Feb 12, 2024
@cyqsimon cyqsimon added the enhancement New feature or request label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants