Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Comments and video player controls inaccessible due to carousel in the way #9174

Closed
1 of 3 tasks
Thinkscape opened this issue Apr 30, 2024 · 2 comments · Fixed by #9455
Closed
1 of 3 tasks

Web: Comments and video player controls inaccessible due to carousel in the way #9174

Thinkscape opened this issue Apr 30, 2024 · 2 comments · Fixed by #9455

Comments

@Thinkscape
Copy link

Thinkscape commented Apr 30, 2024

The bug

The carousel controls seem to have higher z-index and are overlapping the video player, making it impossible to enter FULLSCREEN or use the kebab menu.
It also overlaps the image ❤️ and comments buttons, preventing users from clicking it.

image
image

The OS that Immich Server is running on

Ubuntu 24

Version of Immich Server

v1.103.1

Version of Immich Mobile App

1.102.2 build.151

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

n/a

Your .env content

n/a

Reproduction steps

1. Open web interface
2. Open any video
3. Try switching to full screen

Relevant log output

n/a

Additional information

No response

@Thinkscape Thinkscape changed the title Web: Video player controls inaccesible due to navigation controls z-index Web: Video player controls inaccessible due to carousel in the way Apr 30, 2024
@Snowknight26
Copy link
Contributor

Snowknight26 commented May 8, 2024

Couple notes:

There are a few workarounds:

  • You can enter fullscreen by double clicking the video
  • Resize the browser viewport such that its aspect ratio is wider than the aspect ratio of the video, allowing you to access the controls

Aside from that, it's not really possible to style native browser video controls, so the only solution that I can think of would be to introduce a custom set of controls in lieu of browser controls such that they can be styled properly and/or be in the DOM in the correct position to apply some kind of fix.

@Thinkscape Thinkscape changed the title Web: Video player controls inaccessible due to carousel in the way Web: Comments and video player controls inaccessible due to carousel in the way May 12, 2024
@Thinkscape
Copy link
Author

Thinkscape commented May 12, 2024

  • You can enter fullscreen by double clicking the video

Users don't always want native full screen, and it won't work on mobile.

  • Resize the browser viewport such that its aspect ratio is wider than the aspect ratio of the video, allowing you to access the controls

This is a horrible suggestion... reminds me of late S.Jobs "You're holding it wrong".
Also won't fly with mobile devices where there is no window to drag around.
Also are users expected to drag around the window changing it constantly depending on aspect ratio of different assets?

Aside from that, it's not really possible to style native browser video controls, so the only solution that I can think of would be to introduce a custom set of controls in lieu of browser controls such that they can be styled properly and/or be in the DOM in the correct position to apply some kind of fix.

We should start using proper customisable video player, like video.js, Shaka etc.
Other than that, we could modify the CSS so that the carousel controls don't overlap (assume certain video controls height).

This bug also prevents users accessing the ❤️ and comment section on photos!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants