Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The animation when scrolling through workspace is going into the wrong direction when going between first and last workspace #4527

Open
Azercoco opened this issue Jan 24, 2024 · 5 comments · May be fixed by #4684
Open

The animation when scrolling through workspace is going into the wrong direction when going between first and last workspace #4527

Azercoco opened this issue Jan 24, 2024 · 5 comments · May be fixed by #4684
Labels
bug Something isn't working

Comments

@Azercoco
Copy link

Hyprland Version

System/Version info 
Hyprland, built from branch HEAD at commit 03ebbe18ed8517ee22591eac82cd54322f42cb7d  (props: bump ver to 0.34.0).
Date: Mon Jan 1 12:03:15 2024
Tag: v0.34.0

Bug or Regression?

Bug

Description

When scrolling through the workspace using the workspace, e +/- 1 , the animation direction of going from workspace 1 to the the last is the same than going from 1 to 2. The same applies from going to the last to the first which is also reversed.

How to reproduce

  • Open at least 3 workspaces
  • Scroll between the first and the last
  • The animation is reversed which is confusing for navigation

Crash reports, logs, images, videos

No response
@Azercoco Azercoco added the bug Something isn't working label Jan 24, 2024
@pdamianik
Copy link
Contributor

This animation direction is intentional, as the last workspace is in the same direction as the second workspace from the perspective of the first workspace.
image

As far as I understood you want the option to have the following behavior instead:
image

The relevant code section determining the direction of this animation is in src/helpers/Monitor.cpp:527 in the changeWorkspace function which gets called in src/managers/KeybindManager.cpp:929. I won't implement a Pull Regest for this for now as it is quite late, but I might take another look at it tomorrow.

@pdamianik pdamianik linked a pull request Feb 12, 2024 that will close this issue
Draft
1 task
@pdamianik
Copy link
Contributor

pdamianik commented Feb 12, 2024 •
edited

PR draft is ready: #4684. The option is named binds:animate_workspace_band for now, but I am open for suggestions.

@pdamianik
Copy link
Contributor

#4684 and hyprwm/hyprland-wiki#477 are ready. I am just waiting for feedback from @Azercoco.

@KoyeBosh
Copy link

KoyeBosh commented Feb 28, 2024 •
edited

I propose animations:workspace_wraparound instead, it's more consistent with where other workspace animation setting are configured and imo is a more straightforward name

@pdamianik
Copy link
Contributor

The option is now called animations:workspace_wraparound. Thanks for the suggestion @KoyeBosh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option for animating workspaces as an infinite band pdamianik/Hyprland
3 participants
@Azercoco @pdamianik @KoyeBosh