Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails due to dependency jc-kzg-4844 since version 4.11.0 #2013

Closed
michaelnetter opened this issue Mar 11, 2024 · 9 comments
Closed

Build fails due to dependency jc-kzg-4844 since version 4.11.0 #2013

michaelnetter opened this issue Mar 11, 2024 · 9 comments
Assignees
Labels
needs-review issue/PR needs review from maintainer

Comments

@michaelnetter
Copy link

Issue_title

Build fails due to dependency jc-kzg-4844 since version 4.11.0

Issue_description

I'm using web3j as a dependency in a maven project.
Since version 4.11.0, I am unable to build the project. The error message is the following:

[ERROR] Failed to execute goal on project siwe-java: Could not resolve dependencies for project com.moonstoneid:siwe-java:jar:1.0.5: tech.pegasys:jc-kzg-4844:jar:0.8.0 was not found in https://repo1.maven.org/maven2 during a previous attempt.

It seems the issue is that the dependency jc-kzg-4844 is not available on maven central but only in this third party repository.

This puts developers who use web3j in a difficult spot. They need to either

  • add the repo to their Maven settings.xml -> Must be done by every developer.
  • add the repo to the pom.xml -> URL is hardcoded in the project forever. If the URL changes, this must be changed manually.

Issue_context

The issue was introduced in this pull request.

@michaelnetter michaelnetter added the needs-review issue/PR needs review from maintainer label Mar 11, 2024
@NickSneo NickSneo self-assigned this Mar 13, 2024
@NickSneo
Copy link
Contributor

Hey @michaelnetter ,

jc-kzg-4844 dependency was added so that users can do blob txs following support for EIP4844, let us check what we can do

@michaelnetter
Copy link
Author

Hi @NickSneo,
I highly appreciate your efforts to support EIP-4844 in web3j.
I'm not a maven expert, but to me the cleanest solution would be to ask the developers of jc-kzg-4844 if they might consider publishing it on maven central. A fat jar (using the maven-install-plugin) that includes jc-kzg-4844 into web3j releases could be another option.

@NickSneo
Copy link
Contributor

Hey @michaelnetter,
We are planning to talk to Consensys (developers of jc-kzg-4844) regarding this and moving it to maven central. Will update once we get any confirmations.

Thanks

@michaelnetter
Copy link
Author

Hi @NickSneo,
that sounds great. Thank you for your efforts!

@mmmark0
Copy link

mmmark0 commented Mar 22, 2024

Hi @michaelnetter, I encountered the same error with both version 4.11.0 and 4.11.1.

I currently solved it by using the previous version 4.10.3

@sandronm
Copy link

sandronm commented May 6, 2024

I'm following this thread because I'm facing the same issue :)

@NickSneo
Copy link
Contributor

NickSneo commented May 10, 2024

We are in talks with Consensys team, they will be publishing it to maven central soon.
Opened up an issue to track this progress - Consensys/jc-kzg-4844#42

Link to discussion on Discord (will need to join Hyperledger Server to access this) - https://discord.com/channels/905194001349627914/1195062053682032700/1238389155877359638

@michaelnetter
Copy link
Author

Web3j 4.12.0 fixes the issue. Thanks @NickSneo

@NickSneo
Copy link
Contributor

Thanks for confirming @michaelnetter
Plz use web3j >=4.12.0 for build without Consensys repo dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review issue/PR needs review from maintainer
Projects
None yet
Development

No branches or pull requests

4 participants