Tencent integration test seems to be stuck

That's strange, given there are no integration tests for Tencent (we only have a Placholder object in the test directory)

Is this likely to be an problem on my end?

I can reproduce it locally using ./gradlew :test --tests guide.howto.testing_websocket_clients.GreetingClientTest

I didn't have a chance to look too closely, but I can confirm that test is getting stuck, so I suspect it's either a problem in the JavaWebsocketClient or something related to the test setup.

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 84.51%. Comparing base (4410347) to head (77c28c1).
Report is 3 commits behind head on master.

❗ Current head 77c28c1 differs from pull request most recent head bf32030. Consider uploading reports for the commit bf32030 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##             master    #1061      +/-   ##
============================================
- Coverage     84.53%   84.51%   -0.02%     
- Complexity     2014     2016       +2     
============================================
  Files           579      581       +2     
  Lines         13241    13263      +22     
  Branches       1741     1745       +4     
============================================
+ Hits          11193    11209      +16     
- Misses         1246     1248       +2     
- Partials        802      806       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I fixed my garbage test and the build is passing now. Thanks @s4nchez for finding it for me.

@s4nchez Did you mean to push your server contract changes to this branch?

@oharaandrew314 no, that was a mistake and I've reverted it. Sorry for the confusion.

There is a question about if we can make this work more generally - ie. is the more symmetric implementation os WsHandler a better fit long term for http4k. For this, we'd also need to work out if we can mount it onto a server in the same way as the current implementation.

This could also apply to SSE as well.

I think we're happy enough to support a breaking change as long as it retains the simplicity and testability. We could start with the new interfaces in the incubator package if we want to put it in incrementally and then promote it at the next major version bump.

As long as we can retain the simplicity and testability then it's worth exploring as an option. 😄

Ok. I'll close this for now then.