Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option use the external URL when on mobile data #4402

Open
dani-rodr opened this issue May 14, 2024 · 3 comments
Open

Add an option use the external URL when on mobile data #4402

dani-rodr opened this issue May 14, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@dani-rodr
Copy link

Is your feature request related to a problem? Please describe.

Either of the option in the internal server url settings (dropdown options) needs the location to be turned on. I'm currently using the option that needs to open location setting when outside the home network. This drains my phone battery even faster.

Describe the solution you'd like

Use the external URL when your mobile data connection is on. You don't have to turn on the location in order to check your wifi network.

Describe alternatives you've considered, if any

Additional context

@dani-rodr dani-rodr added the enhancement New feature or request label May 14, 2024
@jpelgrom
Copy link
Member

This is interesting as internal is considered the exception by the app, whereas your request implies external is the exception.

(Practically: implementing "use internal on any WiFi network" is a lot easier to do and explain than conditions for both internal and external use.)

@dani-rodr
Copy link
Author

dani-rodr commented May 14, 2024

The practical solution works for me too. Might be a good option for those who rarely connects to other wifi.

Though I thought you need to turn on location to retrieve wifi settings. I guess it's only needed for the SSID but not the actual wifi state.

@jpelgrom
Copy link
Member

I haven't checked, but if "is the current connection any 4G network" works without location info then "is the current connection any WiFi network" should also work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants